From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752221AbcFFK15 (ORCPT ); Mon, 6 Jun 2016 06:27:57 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33757 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbcFFK1y (ORCPT ); Mon, 6 Jun 2016 06:27:54 -0400 Subject: Re: [PATCH 3/4] serial: 8250_mtk: drop !defined(MODULE) conditional To: Masahiro Yamada , linux-serial@vger.kernel.org References: <1465206063-1018-1-git-send-email-yamada.masahiro@socionext.com> <1465206063-1018-4-git-send-email-yamada.masahiro@socionext.com> Cc: Arnd Bergmann , Peter Hurley , Rob Herring , Paul Burton , Greg Kroah-Hartman , Jiri Slaby , Paul Gortmaker , linux-kernel@vger.kernel.org, Andy Shevchenko , linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Matthias Brugger Message-ID: <57555026.8030400@gmail.com> Date: Mon, 6 Jun 2016 12:27:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <1465206063-1018-4-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/16 11:41, Masahiro Yamada wrote: > The !defined(MODULE) conditional has been added to the > OF_EARLYCON_DECLARE() define. > > This commit partially reverts commit 3f5921a60f74 ("serial: > 8250/mediatek: fix building with SERIAL_8250=m"). > > Signed-off-by: Masahiro Yamada > --- Acked-by: Matthias Brugger > > drivers/tty/serial/8250/8250_mtk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c > index 3489fbc..3611ec9 100644 > --- a/drivers/tty/serial/8250/8250_mtk.c > +++ b/drivers/tty/serial/8250/8250_mtk.c > @@ -301,7 +301,7 @@ static struct platform_driver mtk8250_platform_driver = { > }; > module_platform_driver(mtk8250_platform_driver); > > -#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE) > +#ifdef CONFIG_SERIAL_8250_CONSOLE > static int __init early_mtk8250_setup(struct earlycon_device *device, > const char *options) > { >