From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751760AbcFFL3E (ORCPT ); Mon, 6 Jun 2016 07:29:04 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:65392 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbcFFL3C (ORCPT ); Mon, 6 Jun 2016 07:29:02 -0400 X-AuditID: cbfec7f4-f796c6d000001486-3a-57555e7a038b Subject: Re: [PATCH 5/9] clocksource/drivers/exynos_mct: Convert init function to return error To: Daniel Lezcano , tglx@linutronix.de References: <1464770093-12667-1-git-send-email-daniel.lezcano@linaro.org> <1464770093-12667-6-git-send-email-daniel.lezcano@linaro.org> <575555CC.1020906@samsung.com> <57555D4A.8010001@linaro.org> Cc: linux-kernel@vger.kernel.org, Kukjin Kim , "moderated list:ARM/SAMSUNG EXYNO..." , "moderated list:ARM/SAMSUNG EXYNO..." From: Krzysztof Kozlowski Message-id: <57555E79.80606@samsung.com> Date: Mon, 06 Jun 2016 13:28:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <57555D4A.8010001@linaro.org> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDLMWRmVeSWpSXmKPExsVy+t/xa7pVcaHhBk/mWVjM+yxr8fqFoUX/ 49fMFpseX2O1uLxrDpvFjPP7mCw2b5rK7MDusWlVJ5vHnWt72DzenTvH7rF5Sb1H35ZVjB6f N8kFsEVx2aSk5mSWpRbp2yVwZdy8fYS1YLZQxYlbrewNjHv5uhg5OSQETCQuXDvNCmGLSVy4 t56ti5GLQ0hgKaPEz7WzGUESQgLPGCX+7QrsYuTgEBZIkJi1nxckLCLgJLHt5j5WiPoTjBLP Hr4Ga2YWuMMo8eTXUmaQKjYBY4nNy5ewgdi8AhoSF/bdBrNZBFQlJs6/CFYjKhAhMWv7DyaI GkGJH5PvsYDYnAJaEmv2drCALGYWUJeYMiUXJMwsIC+xec1b5gmMArOQdMxCqJqFpGoBI/Mq RtHU0uSC4qT0XEO94sTc4tK8dL3k/NxNjJAw/7KDcfExq0OMAhyMSjy8K/JDwoVYE8uKK3MP MUpwMCuJ8NoGhoYL8aYkVlalFuXHF5XmpBYfYpTmYFES5527632IkEB6YklqdmpqQWoRTJaJ g1OqgTGT71XL2+V9FtYXH4WdYFr/9uY+3c+efj0zaxdfu6o+Y6kQD1uD0hOWGT57hDM/x77O u5L6JePGr3fljrnfNsndmB7k9F+wxXnvDR29n1/ibyseeqf9qXzZCul17L51KbGMjezt9xha TnVtXHUiS08la/pZBpkjF9h+vtvQsy/iL8/mw0+W5Z1RYinOSDTUYi4qTgQA1Omvzm8CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2016 01:23 PM, Daniel Lezcano wrote: > On 06/06/2016 12:51 PM, Krzysztof Kozlowski wrote: >> On 06/01/2016 10:34 AM, Daniel Lezcano wrote: >>> The init functions do not return any error. They behave as the >>> following: >>> >>> - panic, thus leading to a kernel crash while another timer may >>> work and >>> make the system boot up correctly >>> >>> or >>> >>> - print an error and let the caller unaware if the state of the system >>> >>> Change that by converting the init functions to return an error >>> conforming >>> to the CLOCKSOURCE_OF_RET prototype. >>> >>> Proper error handling (rollback, errno value) will be changed later case >>> by case, thus this change just return back an error or success in the >>> init >>> function. >> >> I don't see the benefits of this change alone. You are replacing one >> non-return code to another always-return-success code. The effect is >> exactly the same. It would make sense to change it to CLOCKSOURCE_OF_RET >> along with proper error handling. >> > > Hi Krzysztof, > > I can understand you expect an error handling but, as stated in the > changelog, proper error handling will be done later. Currently, there > are roughly 80 drivers to changes the init function to return a value in > order change the CLOCKSOURCE_OF_DECLARE macro. That is a quite important > number and changing also the internals will introduce bugs. > > So the series (and there is a huge one coming right after this one), > will focus only on changing the init function to return a value, so we > can swap the clocksource table and rename CLOCKSOURCE_OF_DECLARE_RET > without the '_RET'. I want this to be done before the next PR in order > to prevent to have a double clksrc table. > > If error handling is already taken into account and is trivial, I try to > do the change, otherwise I let the function to return a success value. > > Regarding the important number of drivers, if you have time to change > the init function in the exynos_mct, that will be more than welcome :) Ah, okay, you are planning to get rid of CLOCKSOURCE_OF_DECLARE. I didn't receive the cover letter so the big picture remained hidden. Now it looks good: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof