[PATCH] documentation: ntb.txt correct grammar "however"

[PATCH] documentation: ntb.txt correct grammar "however"

[Justin Keller]

Correct the grammar around the word however. 

Signed-off-by: Justin Keller <justincompsci@gmail.com>

--- 

index 1d9bbab..5d43510 100644
--- a/Documentation/ntb.txt
+++ b/Documentation/ntb.txt
@@ -35,7 +35,7 @@ establishes a logical link to the peer, and creates queue pairs to exchange
 messages and data.  The NTB Netdev then creates an ethernet device using a
 Transport queue pair.  Network data is copied between socket buffers and the
 Transport queue pair buffer.  The Transport client may be used for other things
-besides Netdev, however no other applications have yet been written.
+besides Netdev; however, no other applications have yet been written.
 
 ### NTB Ping Pong Test Client (ntb\_pingpong)

Re: [PATCH] documentation: ntb.txt correct grammar "however"

[Ken Moffat]

On Sat, Jun 04, 2016 at 03:34:01PM -0400, Justin Keller wrote:
> Correct the grammar around the word however. 
> 
> Signed-off-by: Justin Keller <justincompsci@gmail.com>
> 
> --- 
> 
> index 1d9bbab..5d43510 100644
> --- a/Documentation/ntb.txt
> +++ b/Documentation/ntb.txt
> @@ -35,7 +35,7 @@ establishes a logical link to the peer, and creates queue pairs to exchange
>  messages and data.  The NTB Netdev then creates an ethernet device using a
>  Transport queue pair.  Network data is copied between socket buffers and the
>  Transport queue pair buffer.  The Transport client may be used for other things
> -besides Netdev, however no other applications have yet been written.
> +besides Netdev; however, no other applications have yet been written.
>  
>  ### NTB Ping Pong Test Client (ntb\_pingpong)

As a user of British English, the original looks fine.  Your change,
however, looks odd - a semi-colon seems out of place.  If you
replaced it by a full-stop it would look acceptable to me - but not
in any sense better than what is there at the moment.

ĸen
-- 
I had to walk fifteen miles to school, barefoot in the snow.  Uphill both ways.

Re: [PATCH] documentation: ntb.txt correct grammar "however"

[Austin S. Hemmelgarn]

On 2016-06-04 21:36, Ken Moffat wrote:
> On Sat, Jun 04, 2016 at 03:34:01PM -0400, Justin Keller wrote:
>> Correct the grammar around the word however.
>>
>> Signed-off-by: Justin Keller <justincompsci@gmail.com>
>>
>> ---
>>
>> index 1d9bbab..5d43510 100644
>> --- a/Documentation/ntb.txt
>> +++ b/Documentation/ntb.txt
>> @@ -35,7 +35,7 @@ establishes a logical link to the peer, and creates queue pairs to exchange
>>  messages and data.  The NTB Netdev then creates an ethernet device using a
>>  Transport queue pair.  Network data is copied between socket buffers and the
>>  Transport queue pair buffer.  The Transport client may be used for other things
>> -besides Netdev, however no other applications have yet been written.
>> +besides Netdev; however, no other applications have yet been written.
>>
>>  ### NTB Ping Pong Test Client (ntb\_pingpong)
>
> As a user of British English, the original looks fine.  Your change,
> however, looks odd - a semi-colon seems out of place.  If you
> replaced it by a full-stop it would look acceptable to me - but not
> in any sense better than what is there at the moment.
FWIW, the existing usage in the file is common enough in at least 
British, American, and Australian English to be borderline idiomatic 
syntax, but is technically not correct based on traditional punctuation 
rules in any of them.

Personally, I'd leave it as is, especially considering that usage is 
also used by most translation services, and that proper usage of 
semicolons isn't taught much anymore even in collegiate English courses, 
so many younger individuals who speak English natively will think it 
looks odd.

RE: [PATCH] documentation: ntb.txt correct grammar "however"

[Allen Hubbe]

From: Austin S. Hemmelgarn
> On 2016-06-04 21:36, Ken Moffat wrote:
> > On Sat, Jun 04, 2016 at 03:34:01PM -0400, Justin Keller wrote:
> >> Correct the grammar around the word however.

> >> -besides Netdev, however no other applications have yet been written.
> >> +besides Netdev; however, no other applications have yet been written.
> >
> > As a user of British English, the original looks fine.  Your change,
> > however, looks odd - a semi-colon seems out of place.  If you
> > replaced it by a full-stop it would look acceptable to me - but not
> > in any sense better than what is there at the moment.
> FWIW, the existing usage in the file is common enough in at least
> British, American, and Australian English to be borderline idiomatic
> syntax, but is technically not correct based on traditional punctuation
> rules in any of them.
> 
> Personally, I'd leave it as is, especially considering that usage is
> also used by most translation services, and that proper usage of
> semicolons isn't taught much anymore even in collegiate English courses,
> so many younger individuals who speak English natively will think it
> looks odd.

As the however-challenged author, I have no preference one way or any other about the phrasing of this line.

To address others' concerns, perhaps I might suggest a change that resolves the correctness issue without appearing odd: change however to but.

Re: [PATCH] documentation: ntb.txt correct grammar "however"

[Randy Dunlap]

On 06/06/16 12:06, Allen Hubbe wrote:
> From: Austin S. Hemmelgarn
>> On 2016-06-04 21:36, Ken Moffat wrote:
>>> On Sat, Jun 04, 2016 at 03:34:01PM -0400, Justin Keller wrote:
>>>> Correct the grammar around the word however.
> 
>>>> -besides Netdev, however no other applications have yet been written.
>>>> +besides Netdev; however, no other applications have yet been written.
>>>
>>> As a user of British English, the original looks fine.  Your change,
>>> however, looks odd - a semi-colon seems out of place.  If you
>>> replaced it by a full-stop it would look acceptable to me - but not
>>> in any sense better than what is there at the moment.
>> FWIW, the existing usage in the file is common enough in at least
>> British, American, and Australian English to be borderline idiomatic
>> syntax, but is technically not correct based on traditional punctuation
>> rules in any of them.
>>
>> Personally, I'd leave it as is, especially considering that usage is
>> also used by most translation services, and that proper usage of
>> semicolons isn't taught much anymore even in collegiate English courses,
>> so many younger individuals who speak English natively will think it
>> looks odd.
> 
> As the however-challenged author, I have no preference one way or any other about the phrasing of this line.
> 
> To address others' concerns, perhaps I might suggest a change that resolves the correctness issue without appearing odd: change however to but.
> 

I think that the patch is good, but the latter suggestion is sufficient and good enough also.


-- 
~Randy