* [PATCH] ASoC: atmel: fix build failure
@ 2016-06-05 18:00 Sudip Mukherjee
2016-06-06 10:17 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Sudip Mukherjee @ 2016-06-05 18:00 UTC (permalink / raw)
To: Nicolas Ferre, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: linux-kernel, alsa-devel, Sudip Mukherjee
m32r allmodconfig build is failing with the error:
ERROR: "bad_dma_ops" [sound/soc/atmel/snd-soc-atmel-pcm-pdc.ko] undefined!
The code is using DMA but the related dependency is not mentioned in the
Kconfig.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
build log is at:
https://travis-ci.org/sudipm-mukherjee/parport/jobs/134651165
sound/soc/atmel/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
index 06e099e..22aec9a 100644
--- a/sound/soc/atmel/Kconfig
+++ b/sound/soc/atmel/Kconfig
@@ -10,6 +10,7 @@ if SND_ATMEL_SOC
config SND_ATMEL_SOC_PDC
tristate
+ depends on HAS_DMA
default m if SND_ATMEL_SOC_SSC_PDC=m && SND_ATMEL_SOC_SSC=m
default y if SND_ATMEL_SOC_SSC_PDC=y || (SND_ATMEL_SOC_SSC_PDC=m && SND_ATMEL_SOC_SSC=y)
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: atmel: fix build failure
2016-06-05 18:00 [PATCH] ASoC: atmel: fix build failure Sudip Mukherjee
@ 2016-06-06 10:17 ` Mark Brown
2016-06-06 20:58 ` Sudip Mukherjee
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2016-06-06 10:17 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Nicolas Ferre, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
linux-kernel, alsa-devel
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On Sun, Jun 05, 2016 at 07:00:21PM +0100, Sudip Mukherjee wrote:
> m32r allmodconfig build is failing with the error:
> ERROR: "bad_dma_ops" [sound/soc/atmel/snd-soc-atmel-pcm-pdc.ko] undefined!
>
> The code is using DMA but the related dependency is not mentioned in the
> Kconfig.
Rather than going through every single driver using DMA adding the
dependency might it not be simpler to provide at least a stub DMA
implementation for the architectures that don't have it?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: atmel: fix build failure
2016-06-06 10:17 ` Mark Brown
@ 2016-06-06 20:58 ` Sudip Mukherjee
0 siblings, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2016-06-06 20:58 UTC (permalink / raw)
To: Mark Brown, Andrew Morton
Cc: Nicolas Ferre, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
linux-kernel, alsa-devel
On Monday 06 June 2016 11:17 AM, Mark Brown wrote:
> On Sun, Jun 05, 2016 at 07:00:21PM +0100, Sudip Mukherjee wrote:
>> m32r allmodconfig build is failing with the error:
>> ERROR: "bad_dma_ops" [sound/soc/atmel/snd-soc-atmel-pcm-pdc.ko] undefined!
>>
>> The code is using DMA but the related dependency is not mentioned in the
>> Kconfig.
>
> Rather than going through every single driver using DMA adding the
> dependency might it not be simpler to provide at least a stub DMA
> implementation for the architectures that don't have it?
>
Yes, i can add them for m32r. but since m32r is orphan i send all m32r
patches to Andrew.
So, Andrew, do you have any objection to it?
Regards
Sudip
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-06 20:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-05 18:00 [PATCH] ASoC: atmel: fix build failure Sudip Mukherjee
2016-06-06 10:17 ` Mark Brown
2016-06-06 20:58 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox