From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753027AbcFFVbH (ORCPT ); Mon, 6 Jun 2016 17:31:07 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:26989 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751365AbcFFVbF (ORCPT ); Mon, 6 Jun 2016 17:31:05 -0400 X-AuditID: cbfec7f4-f796c6d000001486-ba-5755eb94b750 Subject: Re: [PATCH] usb: usbip: remove null check To: Sudip Mukherjee , Valentina Manea , Shuah Khan , Greg Kroah-Hartman References: <1465248212-5320-1-git-send-email-sudipm.mukherjee@gmail.com> Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, stern@rowland.harvard.edu From: Krzysztof Opasiak Message-id: <5755EB93.3030109@samsung.com> Date: Mon, 06 Jun 2016 23:30:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1465248212-5320-1-git-send-email-sudipm.mukherjee@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOLMWRmVeSWpSXmKPExsVy+t/xy7pTXoeGGzS+ZbdoXryezeLyrjls FouWtTJbfPnMZTHh9wU2iwOnpzBbvLs0l92B3WPnrLvsHvvnrmH3mH33B6NH35ZVjB6fN8kF sEZx2aSk5mSWpRbp2yVwZex/dpm9YCJHxakJz9gbGK+zdTFyckgImEgsW/6XHcIWk7hwbz1Y XEhgKaPEka6ILkYuIPs5o8SWm2tZQRLCAkYS3bOnMIMkRAR2MkpM3XOFEaLDU+JH1xMWEJtZ IEJiV+9UoEkcHGwC+hLzdomCmLwCWhLdh+RBKlgEVCWu3FkCtlcUqHrW9h9MIDavgKDEj8n3 wKZwCnhJzNt8mhGklVlAT+L+RS2I4fISm9e8ZZ7AKDALSccshKpZSKoWMDKvYhRNLU0uKE5K zzXUK07MLS7NS9dLzs/dxAgJ7i87GBcfszrEKMDBqMTDuyI/JFyINbGsuDL3EKMEB7OSCO/b 56HhQrwpiZVVqUX58UWlOanFhxilOViUxHnn7nofIiSQnliSmp2aWpBaBJNl4uCUamAsPMba XeoUxH56fkyzWuHkM49e1vk3e1a92rTgf6mq7eHLp3TaO4/pBrSe0rwQofq0rKLdgvnLuRCT W81HWCaWLVy4tfnzc6nby2238RyL/v1JrqX2F8f8s/0eHuKCa2fOvfJ+wZtFP3dn3EvZUbxw 51211DUCTN4NKuIusyWE3vYs2OXy3KhSiaU4I9FQi7moOBEA/Hid7GoCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2016 11:23 PM, Sudip Mukherjee wrote: > The only caller of get_gadget_descs() has already dereferenced udc > before calling this function, so udc can not be NULL at this point of > the code and hence no use of checking it. > > Signed-off-by: Sudip Mukherjee > --- > drivers/usb/usbip/vudc_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/usbip/vudc_sysfs.c b/drivers/usb/usbip/vudc_sysfs.c > index 99397fa..0f98f2c 100644 > --- a/drivers/usb/usbip/vudc_sysfs.c > +++ b/drivers/usb/usbip/vudc_sysfs.c > @@ -40,7 +40,7 @@ int get_gadget_descs(struct vudc *udc) > struct usb_ctrlrequest req; > int ret; > > - if (!udc || !udc->driver || !udc->pullup) > + if (!udc->driver || !udc->pullup) > return -EINVAL; > > req.bRequestType = USB_DIR_IN | USB_TYPE_STANDARD | USB_RECIP_DEVICE; > Reviewed-by: Krzysztof Opasiak -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics