From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbcFGAwQ (ORCPT ); Mon, 6 Jun 2016 20:52:16 -0400 Received: from regular1.263xmail.com ([211.150.99.131]:50026 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060AbcFGAwO (ORCPT ); Mon, 6 Jun 2016 20:52:14 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: virtualization@lists.linux-foundation.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <74d455fa82f67e6d9a676a210d4ba11e> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 10/20] drm: rockchip: Rely on the default ->best_encoder() behavior To: Boris Brezillon , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Daniel Vetter References: <1464877907-27723-1-git-send-email-boris.brezillon@free-electrons.com> <1464877907-27723-11-git-send-email-boris.brezillon@free-electrons.com> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, Jani Nikula , Alexey Brodkin , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Stefan Agner , Alison Wang , Matthias Brugger , Rob Clark , Laurent Pinchart , Heiko Stuebner , Benjamin Gaignard , Vincent Abriou , Maxime Ripard , Chen-Yu Tsai , Thierry Reding , Stephen Warren , Alexandre Courbot , Eric Anholt , Gerd Hoffmann , linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org From: Mark yao Message-ID: <57561AAA.5060500@rock-chips.com> Date: Tue, 7 Jun 2016 08:51:54 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1464877907-27723-11-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年06月02日 22:31, Boris Brezillon wrote: > All outputss have a 1:1 relationship between connectors and encoders > and the driver is relying on the atomic helpers: we can drop the custom > ->best_encoder() implementations and let the core call > drm_atomic_helper_best_encoder() for us. Good, All connectors and encoders is 1:1 relationship on rockchip outputs, so Acked-by: Mark Yao > > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 9 --------- > drivers/gpu/drm/rockchip/inno_hdmi.c | 9 --------- > 2 files changed, 18 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > index dedc65b..ca22e5e 100644 > --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c > @@ -964,18 +964,9 @@ static enum drm_mode_status dw_mipi_dsi_mode_valid( > return mode_status; > } > > -static struct drm_encoder *dw_mipi_dsi_connector_best_encoder( > - struct drm_connector *connector) > -{ > - struct dw_mipi_dsi *dsi = con_to_dsi(connector); > - > - return &dsi->encoder; > -} > - > static struct drm_connector_helper_funcs dw_mipi_dsi_connector_helper_funcs = { > .get_modes = dw_mipi_dsi_connector_get_modes, > .mode_valid = dw_mipi_dsi_mode_valid, > - .best_encoder = dw_mipi_dsi_connector_best_encoder, > }; > > static enum drm_connector_status > diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c > index f8b4feb..006260d 100644 > --- a/drivers/gpu/drm/rockchip/inno_hdmi.c > +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c > @@ -579,14 +579,6 @@ inno_hdmi_connector_mode_valid(struct drm_connector *connector, > return MODE_OK; > } > > -static struct drm_encoder * > -inno_hdmi_connector_best_encoder(struct drm_connector *connector) > -{ > - struct inno_hdmi *hdmi = to_inno_hdmi(connector); > - > - return &hdmi->encoder; > -} > - > static int > inno_hdmi_probe_single_connector_modes(struct drm_connector *connector, > uint32_t maxX, uint32_t maxY) > @@ -613,7 +605,6 @@ static struct drm_connector_funcs inno_hdmi_connector_funcs = { > static struct drm_connector_helper_funcs inno_hdmi_connector_helper_funcs = { > .get_modes = inno_hdmi_connector_get_modes, > .mode_valid = inno_hdmi_connector_mode_valid, > - .best_encoder = inno_hdmi_connector_best_encoder, > }; > > static int inno_hdmi_register(struct drm_device *drm, struct inno_hdmi *hdmi) -- Ｍark Yao