From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753850AbcFGA6A (ORCPT ); Mon, 6 Jun 2016 20:58:00 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:52647 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752040AbcFGA56 (ORCPT ); Mon, 6 Jun 2016 20:57:58 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 2/2] drm/rockchip: vop: correct the source size of uv scale factor setting To: Yakir Yang , Mark Yao , Heiko Stuebner , David Airlie References: <1465199912-20932-1-git-send-email-ykk@rock-chips.com> <1465199926-20991-1-git-send-email-ykk@rock-chips.com> Cc: tfiga@chromium.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org From: Mark yao Message-ID: <57561C0C.2040507@rock-chips.com> Date: Tue, 7 Jun 2016 08:57:48 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1465199926-20991-1-git-send-email-ykk@rock-chips.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年06月06日 15:58, Yakir Yang wrote: > From: Mark Yao > > When the input color format is YUV, we need to do some external scale > for CBCR. Like, > * In YUV420 data format: > cbcr_xscale = dst_w / src_w * 2; > cbcr_yscale = dst_h / src_h * 2; > * In YUV422 data format: > cbcr_xscale = dst_w / src_w * 2; > cbcr_yscale = dst_h / src_h; > * In YUV444 data format > cbcr_xscale = dst_w / src_w; > cbcr_yscale = dst_h / src_h; > > Signed-off-by: Yakir Yang > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 1c4d5b5..b28cda7 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -324,9 +324,9 @@ static void scl_vop_cal_scl_fac(struct vop *vop, const struct vop_win_data *win, > scl_cal_scale2(src_h, dst_h)); > if (is_yuv) { > VOP_SCL_SET(vop, win, scale_cbcr_x, > - scl_cal_scale2(src_w, dst_w)); > + scl_cal_scale2(cbcr_src_w, dst_w)); > VOP_SCL_SET(vop, win, scale_cbcr_y, > - scl_cal_scale2(src_h, dst_h)); > + scl_cal_scale2(cbcr_src_h, dst_h)); > } > return; > } Thanks for this fix, Applied to my drm-fixes. -- Ｍark Yao