From: Kishon Vijay Abraham I <kishon@ti.com>
To: Lee Jones <lee.jones@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <kernel@stlinux.com>, <maxime.coquelin@st.com>,
<srinivas.kandagatla@gmail.com>, <balbi@kernel.org>,
<gregkh@linuxfoundation.org>, <p.zabel@pengutronix.de>,
<linux-usb@vger.kernel.org>
Subject: Re: [PATCH 8/10] phy: phy-stih407-usb: Inform the reset framework that our reset line may be shared
Date: Tue, 7 Jun 2016 14:30:25 +0530 [thread overview]
Message-ID: <57568D29.6020309@ti.com> (raw)
In-Reply-To: <20160606170854.12407-1-lee.jones@linaro.org>
On Monday 06 June 2016 10:38 PM, Lee Jones wrote:
> On the STiH410 B2120 development board the ports on the Generic PHY
> share their reset lines with each other. New functionality in the
> reset subsystems forces consumers to be explicit when requesting
> shared/exclusive reset lines.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> drivers/phy/phy-stih407-usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/phy-stih407-usb.c b/drivers/phy/phy-stih407-usb.c
> index 1d5ae5f..b1f44ab 100644
> --- a/drivers/phy/phy-stih407-usb.c
> +++ b/drivers/phy/phy-stih407-usb.c
> @@ -105,13 +105,13 @@ static int stih407_usb2_picophy_probe(struct platform_device *pdev)
> phy_dev->dev = dev;
> dev_set_drvdata(dev, phy_dev);
>
> - phy_dev->rstc = devm_reset_control_get(dev, "global");
> + phy_dev->rstc = devm_reset_control_get_shared(dev, "global");
> if (IS_ERR(phy_dev->rstc)) {
> dev_err(dev, "failed to ctrl picoPHY reset\n");
> return PTR_ERR(phy_dev->rstc);
> }
>
> - phy_dev->rstport = devm_reset_control_get(dev, "port");
> + phy_dev->rstport = devm_reset_control_get_exclusive(dev, "port");
> if (IS_ERR(phy_dev->rstport)) {
> dev_err(dev, "failed to ctrl picoPHY reset\n");
> return PTR_ERR(phy_dev->rstport);
>
next prev parent reply other threads:[~2016-06-07 9:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 15:56 [PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines Lee Jones
2016-06-06 15:56 ` [PATCH 1/7] reset: Reorder inline reset_control_get*() wrappers Lee Jones
2016-06-20 12:07 ` Philipp Zabel
2016-06-06 15:56 ` [PATCH 2/7] reset: Ensure drivers are explicit when requesting reset lines Lee Jones
2016-06-06 15:56 ` [PATCH 3/7] reset: Supply *_shared variant calls when using of_* API Lee Jones
2016-06-06 15:56 ` [PATCH 4/7] reset: Supply *_shared variant calls when using *_optional APIs Lee Jones
2016-06-28 8:56 ` Lee Jones
2016-06-29 7:48 ` Philipp Zabel
2016-06-29 8:06 ` Lee Jones
2016-06-29 9:23 ` Philipp Zabel
2016-06-29 9:37 ` Lee Jones
2016-06-29 21:57 ` Philipp Zabel
2016-06-06 15:56 ` [PATCH 5/7] reset: TRIVIAL: Add line break at same place for similar APIs Lee Jones
2016-06-06 15:56 ` [PATCH 6/7] phy: miphy28lp: Inform the reset framework that our reset line may be shared Lee Jones
2016-06-07 8:37 ` [STLinux Kernel] " Peter Griffin
2016-06-07 8:59 ` Kishon Vijay Abraham I
2016-06-28 7:55 ` Lee Jones
2016-06-06 15:56 ` [PATCH 7/7] usb: dwc3: st: " Lee Jones
2016-06-06 17:08 ` [PATCH 8/10] phy: phy-stih407-usb: " Lee Jones
2016-06-06 17:08 ` [PATCH 9/10] usb: host: ehci-st: " Lee Jones
2016-06-06 17:44 ` Alan Stern
2016-06-28 7:58 ` Lee Jones
2016-06-28 8:01 ` Lee Jones
2016-06-07 8:36 ` [STLinux Kernel] " Peter Griffin
2016-06-06 17:08 ` [PATCH 10/10] usb: host: ohci-st: " Lee Jones
2016-06-07 8:36 ` [STLinux Kernel] [PATCH 8/10] phy: phy-stih407-usb: " Peter Griffin
2016-06-07 9:00 ` Kishon Vijay Abraham I [this message]
2016-06-07 8:36 ` [STLinux Kernel] [PATCH 7/7] usb: dwc3: st: " Peter Griffin
2016-06-16 9:03 ` Philipp Zabel
2016-06-28 9:27 ` [PATCH 1/1] " Lee Jones
2016-06-29 6:33 ` Felipe Balbi
2016-06-07 8:42 ` [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines Peter Griffin
2016-06-07 9:15 ` Lee Jones
2016-06-07 9:24 ` Lee Jones
2016-06-16 9:03 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57568D29.6020309@ti.com \
--to=kishon@ti.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=p.zabel@pengutronix.de \
--cc=srinivas.kandagatla@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).