From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754654AbcFGJBf (ORCPT ); Tue, 7 Jun 2016 05:01:35 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:49727 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753983AbcFGJBd (ORCPT ); Tue, 7 Jun 2016 05:01:33 -0400 Subject: Re: [PATCH 8/10] phy: phy-stih407-usb: Inform the reset framework that our reset line may be shared To: Lee Jones , , References: <20160606155655.10860-8-lee.jones@linaro.org> <20160606170854.12407-1-lee.jones@linaro.org> CC: , , , , , , From: Kishon Vijay Abraham I Message-ID: <57568D29.6020309@ti.com> Date: Tue, 7 Jun 2016 14:30:25 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160606170854.12407-1-lee.jones@linaro.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 06 June 2016 10:38 PM, Lee Jones wrote: > On the STiH410 B2120 development board the ports on the Generic PHY > share their reset lines with each other. New functionality in the > reset subsystems forces consumers to be explicit when requesting > shared/exclusive reset lines. > > Signed-off-by: Lee Jones Acked-by: Kishon Vijay Abraham I > --- > drivers/phy/phy-stih407-usb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/phy-stih407-usb.c b/drivers/phy/phy-stih407-usb.c > index 1d5ae5f..b1f44ab 100644 > --- a/drivers/phy/phy-stih407-usb.c > +++ b/drivers/phy/phy-stih407-usb.c > @@ -105,13 +105,13 @@ static int stih407_usb2_picophy_probe(struct platform_device *pdev) > phy_dev->dev = dev; > dev_set_drvdata(dev, phy_dev); > > - phy_dev->rstc = devm_reset_control_get(dev, "global"); > + phy_dev->rstc = devm_reset_control_get_shared(dev, "global"); > if (IS_ERR(phy_dev->rstc)) { > dev_err(dev, "failed to ctrl picoPHY reset\n"); > return PTR_ERR(phy_dev->rstc); > } > > - phy_dev->rstport = devm_reset_control_get(dev, "port"); > + phy_dev->rstport = devm_reset_control_get_exclusive(dev, "port"); > if (IS_ERR(phy_dev->rstport)) { > dev_err(dev, "failed to ctrl picoPHY reset\n"); > return PTR_ERR(phy_dev->rstport); >