From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932292AbcFGJU5 (ORCPT ); Tue, 7 Jun 2016 05:20:57 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:9803 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932233AbcFGJUz (ORCPT ); Tue, 7 Jun 2016 05:20:55 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 07 Jun 2016 02:18:38 -0700 Subject: Re: [PATCH] pinctrl: tegra: Fix build dependency To: Axel Lin , Linus Walleij References: <1465022156.547.2.camel@ingics.com> <5756913F.1000108@nvidia.com> CC: Stephen Warren , Thierry Reding , , From: Jon Hunter Message-ID: <575691EE.8020409@nvidia.com> Date: Tue, 7 Jun 2016 10:20:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <5756913F.1000108@nvidia.com> X-Originating-IP: [10.21.132.106] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL102.nvidia.com (10.26.138.15) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/16 10:17, Jon Hunter wrote: > > On 04/06/16 07:35, Axel Lin wrote: >> I got below build error: >> ERROR: "tegra_xusb_padctl_legacy_probe" [drivers/phy/tegra/phy-tegra-xusb.ko] undefined! >> with below build configuration: >> CONFIG_ARCH_TEGRA=y >> CONFIG_PINCTRL_TEGRA_XUSB=y >> CONFIG_PHY_TEGRA_XUSB=y > > The above does not make sense because the error is from building a > module but you say you have CONFIG_PINCTRL_TEGRA_XUSB=y. Shouldn't this > be CONFIG_PINCTRL_TEGRA_XUSB=m? However, the error will occur either if > you compile as a module or not, but the changelog should be accurate > nonetheless. Sorry I meant CONFIG_PHY_TEGRA_XUSB=m and NOT CONFIG_PINCTRL_TEGRA_XUSB=m as you are building the phy-tegra-xusb as a module. Jon -- nvpublic