From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754463AbcFGJ3O (ORCPT ); Tue, 7 Jun 2016 05:29:14 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:17523 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754312AbcFGJ3I (ORCPT ); Tue, 7 Jun 2016 05:29:08 -0400 X-AuditID: cbfec7f5-f792a6d000001302-05-575693dfab8e Subject: Re: [PATCH v3 06/12] power: pwrseq: simple: Add support for regulator and generic property To: Rob Herring References: <1464768141-25420-1-git-send-email-k.kozlowski@samsung.com> <1464768141-25420-7-git-send-email-k.kozlowski@samsung.com> <20160603020218.GA19436@rob-hp-laptop> Cc: hzpeterchen@gmail.com, Ulf Hansson , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Javier Martinez Canillas , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-pm@vger.kernel.or, Alan Stern , linux-usb@vger.kernel.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <575693DE.2010603@samsung.com> Date: Tue, 07 Jun 2016 11:29:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <20160603020218.GA19436@rob-hp-laptop> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrPIsWRmVeSWpSXmKPExsVy+t/xq7r3J4eFG/w9YWqxccZ6VotJT94z W8w/co7VYuLKycwW/W8Wslo0L17PZtF1dRObxblXKxkt3rxdw2Tx+oWhRf/j18wWmx5fY7W4 vGsOm8WR//2MFjMvrmaxmHF+H5PFomWtzBZLr19kspgwfS2Lxf89O9gtTu8usZjw+wKbxfG1 4Q7iHmvmrWH0uNzXy+Sxc9Zddo+Vy7+weWxeoeWxaVUnm8eda3vYPPbPXcPusXlJvceWfqCC 2Xd/MHr0bVnF6HHk63QWj8+b5AL4orhsUlJzMstSi/TtErgydu09xFawhrNi56x9LA2Mu9i7 GDk5JARMJKbvP8QEYYtJXLi3nq2LkYtDSGApo8T0KbOZIZxnjBJbVxwGqxIWSJXomdoLZosI KEr8bpvGClG0jlHi7MyNYA6zwAI2iVuHHjCCVLEJGEtsXr6EDWKHnERv9yQWEJtXQEviye4+ ZhCbRUBV4v+6vWA1ogIRErO2/2CCqBGU+DH5HlA9Bwcn0JwD57hBTGYBPYn7F7VAKpgF5CU2 r3nLPIFRcBaShlkIVbOQVC1gZF7FKJpamlxQnJSea6RXnJhbXJqXrpecn7uJERLtX3cwLj1m dYhRgINRiYd3x5fQcCHWxLLiytxDjBIczEoivJoTw8KFeFMSK6tSi/Lji0pzUosPMUpzsCiJ 887c9T5ESCA9sSQ1OzW1ILUIJsvEwSnVwLikm+d56DGpXtPYs0EqU3bGfJ81bVHXn59GFV78 Ti7c651fyx2UOZ55OuXpf6vDnjX3DmzRWHg153FwH5fkjxSx+29OGs3tmrzuxN9ygcXranda SpXYRQdwHDvZfINh4i5tzs/xk+y1d8iw6J3J0U/o8t+xcfLfBdEVJ91sLj1rfvc1KftzvpkS S3FGoqEWc1FxIgCiSE/m8gIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03/2016 04:02 AM, Rob Herring wrote: >> Optional properties: >> - reset-gpios : contains a list of GPIO specifiers. The reset GPIOs are asserted >> @@ -16,6 +22,7 @@ Optional properties: >> See ../clocks/clock-bindings.txt for details. >> - clock-names : Must include the following entry: >> "ext_clock" (External clock provided to the card). >> +- ext-supply : External regulator supply > > What happens when there are 2 supplies? > > I'd prefer the name not be genericish and use the real supply names. > Then the power seq code should just turn on all supplies it finds. If > the order or timing to turn on matters, then sorry, no generic sequence. I think the generic part for regulators might be a problem. Regulator API requires a name for the supply... it cannot get "something" or "everything". The driver could attach itself to any kind of node (where power-sequence property exists) so the supply name depends on the bindings of device (not bindings of power sequence driver). The power sequence driver could however iterate over child properties and get the names of all supplies. It is a little bit ugly... Best regards, Krzysztof