Re: [PATCH v3] ASoC: rockchip: Add machine driver for MAX98357A/RT5514/DA7219

Mark Brown
2016-06-07T10:47:50Z

[-- Attachment #1: Type: text/plain, Size: 934 bytes --]

On Tue, Jun 07, 2016 at 10:49:35AM +0800, Xing Zheng wrote:
> On 2016年06月07日 07:50, Mark Brown wrote:

> > It should probably be three compatibles, one per CODEC, if the driver
> > needs to handle each separately.

> Do you mean like this:
> --------
> sound {
> compatible = "rockchip,rk3399-max98357a-rt5514-da7219";
>
> dailink-0 {
> compatible = "rockchip,rk3399-max98357a";
> rockchip,cpu = <&i2s0>;
> rockchip,codec = <&max98357a>;
> };
>
> dailink-1 {
> compatible = "rockchip,rk3399-rt5514";
> rockchip,cpu = <&i2s0>;
> rockchip,codec = <&headsetcodec>;
> };
>
> dailink-2 {
> compatible = "rockchip,rk3399-da7219";
> rockchip,cpu = <&i2s0>;
> rockchip,codec = <&codec>;
> };
> };
> --------
> Above, the machine drvier will handle them. Please correct me if I
> misunderstand.

No, that'd be one card with all three CODECs on the same board which I'm
guessing isn't the intention?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]