From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754380AbcFGMtY (ORCPT ); Tue, 7 Jun 2016 08:49:24 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:39194 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752727AbcFGMtX (ORCPT ); Tue, 7 Jun 2016 08:49:23 -0400 Subject: Re: [PATCH v10 2/7] usb: mux: add generic code for dual role port mux To: Lu Baolu , Jun Li , Peter Chen References: <1464831449-8973-1-git-send-email-baolu.lu@linux.intel.com> <1464831449-8973-3-git-send-email-baolu.lu@linux.intel.com> <20160603074113.GA30006@shlinux2> <5751AAEE.2090001@linux.intel.com> <20160604022838.GA26936@shlinux2> <5753CCFC.2060504@linux.intel.com> <20160606012557.GA16012@shlinux2> <5754E850.1020707@linux.intel.com> <57552006.7080108@ti.com> <57566941.6040109@linux.intel.com> <5756938E.2010901@linux.intel.com> CC: "felipe.balbi@linux.intel.com" , Mathias Nyman , Greg Kroah-Hartman , Lee Jones , Heikki Krogerus , Liam Girdwood , Mark Brown , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Roger Quadros Message-ID: <5756C2C7.5070902@ti.com> Date: Tue, 7 Jun 2016 15:49:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <5756938E.2010901@linux.intel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/16 12:27, Lu Baolu wrote: > Hi, > > On 06/07/2016 02:34 PM, Jun Li wrote: >>>> On 06/07/2016 11:03 AM, Jun Li wrote: >>>>>> Hi Roger >>>>>> >>>>>>>> >>>>>>>> For Mux devices implementing dual-role, the mux device driver _must_ >>>>>>>> use OTG/dual-role core API so that a common ABI is presented to user >>>>>>>> space for OTG/dual-role. >>>>>> That's the only point we have concern, do dual role switch through >>>>>> OTG/dual-role core, not do it by itself. >>>> >>>> That really depends on how do you define "dual role". Can you please >>>> provide an unambiguous definition of "dual role" used in OTG/dual-role >>>> framework? >> Host and peripheral. >> > > This is definitely ambiguous. > > By reading OTG/dual-role code, my understanding is that "dual-role" is a > "reduced OTG" which is for DRD devices lacking of some OTG negotiation > protocols. DRD means dual role with zero OTG features, which is similar to just host and peripheral mode. > > We really can't say "it's the scope of OTG/dual-role" whenever it comes to > "host and peripheral". What other combination you foresee? cheers, -roger