From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755347AbcFGOHt (ORCPT ); Tue, 7 Jun 2016 10:07:49 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:28483 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755171AbcFGOHF (ORCPT ); Tue, 7 Jun 2016 10:07:05 -0400 Subject: Re: [PATCH v2 2/2] xen-pciback: clean up {bar,rom}_init() To: Jan Beulich , David Vrabel , Konrad Rzeszutek Wilk , Juergen Gross References: <5756857802000078000F268D@prv-mh.provo.novell.com> <5756866F02000078000F269D@prv-mh.provo.novell.com> Cc: xen-devel , linux-kernel@vger.kernel.org From: Boris Ostrovsky Message-ID: <5756D4FF.7010403@oracle.com> Date: Tue, 7 Jun 2016 10:06:55 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <5756866F02000078000F269D@prv-mh.provo.novell.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/07/2016 02:31 AM, Jan Beulich wrote: > - drop unused function parameter of read_dev_bar() > - drop rom_init() (now identical to bar_init()) > - fold read_dev_bar() into its now single caller > - simplify determination of 64-bit memory resource > - use const and unsigned > > Signed-off-by: Jan Beulich Reviewed-by: Boris Ostrovsky