From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161601AbcFGQsf (ORCPT ); Tue, 7 Jun 2016 12:48:35 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:35919 "EHLO mail-it0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161848AbcFGQsT (ORCPT ); Tue, 7 Jun 2016 12:48:19 -0400 Subject: Re: [PATCH] Missing bio_put following submit_bio_wait To: Shaun Tancheff , linux-block@vger.kernel.org References: <1465316612-9649-1-git-send-email-shaun@tancheff.com> <1465317133-13266-1-git-send-email-shaun@tancheff.com> Cc: Christoph Hellwig , David Drysdale , Xiong Zhou , Stephen Rothwell , linux-next@vger.kernel.org, linux-nvdimm@ml01.01.org, Larry Finger , Catalin Marinas , LKML , Jens Axboe , bart.vanassche@sandisk.com, Shaun Tancheff From: Jens Axboe Message-ID: <5756FACF.8030202@kernel.dk> Date: Tue, 7 Jun 2016 10:48:15 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1465317133-13266-1-git-send-email-shaun@tancheff.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/07/2016 10:32 AM, Shaun Tancheff wrote: > submit_bio_wait() gives the caller an opportunity to examine > struct bio and so expects the caller to issue the put_bio() > > This fixes a memory leak reported by a few people in 4.7-rc2 > kmemleak report after 9082e87bfbf8 ("block: remove struct bio_batch") > > Signed-off-by: Shaun Tancheff > Tested-by: Catalin Marinas > Tested-by: Larry Finger@lwfinger.net > Tested-by: David Drysdale Thanks, applied. -- Jens Axboe