From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161512AbcFGTLv (ORCPT ); Tue, 7 Jun 2016 15:11:51 -0400 Received: from us-mx1.synaptics.com ([192.147.44.131]:52740 "EHLO us-mx1.synaptics.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965AbcFGTLt (ORCPT ); Tue, 7 Jun 2016 15:11:49 -0400 Subject: Re: [PATCH 3/7] Input: synaptics-rmi4: Add dribble and palm gesture parameters to devicetree To: Mark Rutland References: <1464979228-2497-1-git-send-email-aduggan@synaptics.com> <20160603185720.GA5204@leverpostej> CC: , , Dmitry Torokhov , Linus Walleij , Jiri Kosina , Benjamin Tissoires , Vincent Huang , Nick Dyer , From: Andrew Duggan Message-ID: <57571C73.4080209@synaptics.com> Date: Tue, 7 Jun 2016 12:11:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160603185720.GA5204@leverpostej> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.4.10.103] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, Thanks for reviewing. On 06/03/2016 11:57 AM, Mark Rutland wrote: > On Fri, Jun 03, 2016 at 11:40:28AM -0700, Andrew Duggan wrote: >> Signed-off-by: Andrew Duggan >> --- >> .../devicetree/bindings/input/rmi4/rmi_2d_sensor.txt | 5 +++++ >> drivers/input/rmi4/rmi_2d_sensor.c | 14 ++++++++++++++ >> 2 files changed, 19 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt >> index f2c30c8..822df11 100644 >> --- a/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt >> +++ b/Documentation/devicetree/bindings/input/rmi4/rmi_2d_sensor.txt >> @@ -37,6 +37,11 @@ Optional Properties: >> disable reporing absolute position data. >> - syna,rezero-wait-ms: Time in miliseconds to wait after issuing a rezero >> command. >> +- syna,dribble: Control reporting of dribble packets. Values are 0 for >> + default, 1 for explicitly disable, 2 for explicitly enable. > This sounds like a driver option one might choose at runtime, not a > fixed hardware/integration property. > > Why does this belong in the DT? My intention is to enable or disable these properties on a platform basis. Dribble packets could be enabled on platforms which have issues reliably reporting data. Dribble packets report multiple finger lift events when a finger leaves the touchpad. The default will be to disable them, but if a platform does not reliably report data (examples we have observed are issues with the I2C controller) then the additional finger lift events could avoid fingers from becoming "stuck" when the host does not receive a finger lift event. >> +- syna,palm_detect: Control reporting of the palm detect gesture. Values >> + are 0 for default, 1 for explicitly disable, 2 for >> + explicitly enable. > Likewise, same question here. Similarly, this property was added to disable this functionality on a particular platform where it was causing interference. Since there properties are set in firmware which is generally configured per platform I went ahead and added them to the device tree bindings. > Additionally, please use '-', not '_' in property names. Sorry, Rob gave me similar feedback for previous properties. But, I must have forgotten when making this change. I can fix this if we decide to keep these properties in devicetree. Thanks, Andrew > Thanks, > Mark.