From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1161069AbcFGXqK (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Jun 2016 19:46:10 -0400
Received: from mail-out.m-online.net ([212.18.0.9]:53320 "EHLO
	mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932706AbcFGXqI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Jun 2016 19:46:08 -0400
X-Auth-Info: b6fyBfgeMzcO7eSNXksLivZGnvOERMl+skS/nqtl7XU=
Message-ID: <57575CB9.8020808@denx.de>
Date: Wed, 08 Jun 2016 01:46:01 +0200
From: Marek Vasut <marex@denx.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0
MIME-Version: 1.0
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Nicolas Ferre <nicolas.ferre@atmel.com>
CC: Boris Brezillon <boris.brezillon@free-electrons.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: at91: ma5d4: properly define crystals frequencies
References: <1465342279-9193-1-git-send-email-alexandre.belloni@free-electrons.com>
In-Reply-To: <1465342279-9193-1-git-send-email-alexandre.belloni@free-electrons.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/08/2016 01:31 AM, Alexandre Belloni wrote:
> The Denx MA5D4 dts doesn't properly define the slow_xtal and main_xtal
> frequencies, the PMC then has to fallback to using the RC oscillators whose
> precision is not really good.
> 
> As both crystals are populated, define their frequencies, see p17 of
> http://www.denx-cs.de/sites/all/files/MA5D4.HWM_.002.pdf
> 
> Also, remove the obsolete main_clock definition.
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

That's correct, I had similar patch in my tree.

Acked-by: Marek Vasut <marex@denx.de>

Thanks!

> ---
>  arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi b/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
> index e7b2109fc85a..99d57131782f 100644
> --- a/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
> +++ b/arch/arm/boot/dts/at91-sama5d4_ma5d4.dtsi
> @@ -20,8 +20,11 @@
>  	};
>  
>  	clocks {
> -		main_clock: main_clock {
> -			compatible = "atmel,osc", "fixed-clock";
> +		slow_xtal {
> +			clock-frequency = <32768>;
> +		};
> +
> +		main_xtal {
>  			clock-frequency = <12000000>;
>  		};
>  
> 


-- 
Best regards,
Marek Vasut