From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424119AbcFHJqt (ORCPT ); Wed, 8 Jun 2016 05:46:49 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:45602 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161478AbcFHJqq (ORCPT ); Wed, 8 Jun 2016 05:46:46 -0400 Subject: Re: [PATCH 1/2] gpiolib: Fix NULL pointer deference To: Linus Walleij , Ricardo Ribalda Delgado , Roger Quadros References: <1464973802-9286-1-git-send-email-ricardo.ribalda@gmail.com> CC: Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Grygorii Strashko Message-ID: <5757E982.1040902@ti.com> Date: Wed, 8 Jun 2016 12:46:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08/2016 11:39 AM, Linus Walleij wrote: > On Fri, Jun 3, 2016 at 7:10 PM, Ricardo Ribalda Delgado > wrote: > >> Under some circumstances, a gpiochip might be half cleaned from the >> gpio_device list. >> >> This patch makes sure that the chip pointer is still valid, before >> calling the match function. >> >> [ 104.088296] BUG: unable to handle kernel NULL pointer dereference at >> 0000000000000090 >> [ 104.089772] IP: [] of_gpiochip_find_and_xlate+0x15/0x80 >> [ 104.128273] Call Trace: >> [ 104.129802] [] ? of_parse_own_gpio+0x1f0/0x1f0 >> [ 104.131353] [] gpiochip_find+0x60/0x90 >> [ 104.132868] [] of_get_named_gpiod_flags+0x9a/0x120 >> ... >> [ 104.141586] [] gpio_led_probe+0x11b/0x360 >> >> Signed-off-by: Ricardo Ribalda Delgado > > Oh there is the fix that Roger and Grygorii needs. > > Applied to fixes and tagged for stable. > > Sorry for screwing things up :( > Np. :) -- regards, -grygorii