From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424394AbcFHJyh (ORCPT ); Wed, 8 Jun 2016 05:54:37 -0400 Received: from smtp113.iad3a.emailsrvr.com ([173.203.187.113]:33491 "EHLO smtp113.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423385AbcFHJy3 (ORCPT ); Wed, 8 Jun 2016 05:54:29 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH 5/5] Staging: comedi: dmm32at: Prefer using the BIT macro To: Ravishankar Karkala Mallikarjunayya , hsweeten@visionengravers.com, gregkh@linuxfoundation.org References: <1465363832-9585-1-git-send-email-ravishankarkm32@gmail.com> <1465363832-9585-5-git-send-email-ravishankarkm32@gmail.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <5757EB51.5040902@mev.co.uk> Date: Wed, 8 Jun 2016 10:54:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1465363832-9585-5-git-send-email-ravishankarkm32@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/06/16 06:30, Ravishankar Karkala Mallikarjunayya wrote: > This fixes all occurences of (1< "CHECK" output "Prefer using the BIT macro" > > Signed-off-by: Ravishankar Karkala Mallikarjunayya > --- > drivers/staging/comedi/drivers/dmm32at.c | 86 ++++++++++++++++---------------- > 1 file changed, 43 insertions(+), 43 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/dmm32at.c b/drivers/staging/comedi/drivers/dmm32at.c > index 958c0d4..4ca6104 100644 > --- a/drivers/staging/comedi/drivers/dmm32at.c > +++ b/drivers/staging/comedi/drivers/dmm32at.c Most of these are fine, but... [snip] > #define DMM32AT_CTRL_PAGE_8254 (0 << 0) > -#define DMM32AT_CTRL_PAGE_8255 (1 << 0) > +#define DMM32AT_CTRL_PAGE_8255 BIT(0) > #define DMM32AT_CTRL_PAGE_CALIB (3 << 0) That one makes the code less readable as the above three macros are for the same bitfield, and should have similar-looking macro expansions. [snip] > #define DMM32AT_AI_CFG_SCINT_20US (0 << 4) > -#define DMM32AT_AI_CFG_SCINT_15US (1 << 4) > +#define DMM32AT_AI_CFG_SCINT_15US BIT(4) > #define DMM32AT_AI_CFG_SCINT_10US (2 << 4) > #define DMM32AT_AI_CFG_SCINT_5US (3 << 4) The same thing here. [snip] -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-