From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754618AbcFHLRQ (ORCPT ); Wed, 8 Jun 2016 07:17:16 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35758 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753235AbcFHLRM (ORCPT ); Wed, 8 Jun 2016 07:17:12 -0400 Subject: Re: [PATCH v2 07/20] drm: mediatek: Rely on the default ->best_encoder() behavior To: Boris Brezillon , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Daniel Vetter References: <1465300095-16971-1-git-send-email-boris.brezillon@free-electrons.com> <1465300095-16971-8-git-send-email-boris.brezillon@free-electrons.com> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, intel-gfx@lists.freedesktop.org, Jani Nikula , Alexey Brodkin , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Stefan Agner , Alison Wang , Rob Clark , Laurent Pinchart , Mark Yao , Heiko Stuebner , Benjamin Gaignard , Vincent Abriou , Maxime Ripard , Chen-Yu Tsai , Thierry Reding , Stephen Warren , Alexandre Courbot , Eric Anholt , Gerd Hoffmann , linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org, virtualization@lists.linux-foundation.org From: Matthias Brugger Message-ID: <5757FEB3.8050001@gmail.com> Date: Wed, 8 Jun 2016 13:17:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <1465300095-16971-8-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/16 13:48, Boris Brezillon wrote: > We have a 1:1 relationship between connectors and encoders and the > driver is relying on the atomic helpers: we can drop the custom > ->best_encoder() implementation and let the core call > drm_atomic_helper_best_encoder() for us. > > Signed-off-by: Boris Brezillon Reviewed-by: Matthias Brugger > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 2d808e5..7343ffc 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -575,14 +575,6 @@ static int mtk_dsi_connector_get_modes(struct drm_connector *connector) > return drm_panel_get_modes(dsi->panel); > } > > -static struct drm_encoder *mtk_dsi_connector_best_encoder( > - struct drm_connector *connector) > -{ > - struct mtk_dsi *dsi = connector_to_dsi(connector); > - > - return &dsi->encoder; > -} > - > static const struct drm_encoder_helper_funcs mtk_dsi_encoder_helper_funcs = { > .mode_fixup = mtk_dsi_encoder_mode_fixup, > .mode_set = mtk_dsi_encoder_mode_set, > @@ -603,7 +595,6 @@ static const struct drm_connector_funcs mtk_dsi_connector_funcs = { > static const struct drm_connector_helper_funcs > mtk_dsi_connector_helper_funcs = { > .get_modes = mtk_dsi_connector_get_modes, > - .best_encoder = mtk_dsi_connector_best_encoder, > }; > > static int mtk_drm_attach_bridge(struct drm_bridge *bridge, >