From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424752AbcFHQLX (ORCPT ); Wed, 8 Jun 2016 12:11:23 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:60701 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423156AbcFHQLT (ORCPT ); Wed, 8 Jun 2016 12:11:19 -0400 Subject: Re: [PATCH 3/8] mfd: tps65218: Use mfd_add_devices instead of of_platform_populate To: Lee Jones , Keerthy References: <1462945691-904-1-git-send-email-j-keerthy@ti.com> <1462945691-904-4-git-send-email-j-keerthy@ti.com> <20160608155025.GB14888@dell> CC: , , , , , , , , , From: Keerthy Message-ID: <57584349.7000906@ti.com> Date: Wed, 8 Jun 2016 21:39:45 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20160608155025.GB14888@dell> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 08 June 2016 09:20 PM, Lee Jones wrote: > On Wed, 11 May 2016, Keerthy wrote: > >> mfd_add_devices enables parsing device tree nodes without compatibles >> for child nodes. Replace of_platform_populate with mfd_add_devices. >> >> Signed-off-by: Keerthy >> --- >> drivers/mfd/tps65218.c | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c >> index f20a531..b8b3a58 100644 >> --- a/drivers/mfd/tps65218.c >> +++ b/drivers/mfd/tps65218.c >> @@ -33,6 +33,10 @@ >> >> #define TPS65218_PASSWORD_REGS_UNLOCK 0x7D >> >> +static const struct mfd_cell tps65218_cells[] = { >> + { .name = "tps65218-regulator", }, >> +}; > > What other devices does the TPS65218 consist of? As of now only regulators driver is in kernel. The PMIC contains a bunch of GPIOs, Over temperature warning / shutdown unit. > >> /** >> * tps65218_reg_write: Write a single tps65218 register. >> * >> @@ -236,8 +240,10 @@ static int tps65218_probe(struct i2c_client *client, >> if (ret < 0) >> return ret; >> >> - ret = of_platform_populate(client->dev.of_node, NULL, NULL, >> - &client->dev); >> + ret = mfd_add_devices(tps->dev, PLATFORM_DEVID_AUTO, tps65218_cells, >> + ARRAY_SIZE(tps65218_cells), NULL, 0, >> + regmap_irq_get_domain(tps->irq_data)); >> + >> if (ret < 0) >> goto err_irq; >> >