From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424497AbcFHQKY (ORCPT ); Wed, 8 Jun 2016 12:10:24 -0400 Received: from mail2.candelatech.com ([208.74.158.173]:57671 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423156AbcFHQKW (ORCPT ); Wed, 8 Jun 2016 12:10:22 -0400 Subject: Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns To: Prasun Maiti References: <1465388474-20503-1-git-send-email-prasunmaiti87@gmail.com> <87wplzkbd9.fsf@kamboji.qca.qualcomm.com> <87porrkaax.fsf@kamboji.qca.qualcomm.com> <87d1nrk89v.fsf@kamboji.qca.qualcomm.com> <57583EFC.3070901@candelatech.com> Cc: "Valo, Kalle" , Linux Next , "ath6kl@lists.infradead.org" , Linux Wireless , Linux Kernel From: Ben Greear Organization: Candela Technologies Message-ID: <5758436C.3000707@candelatech.com> Date: Wed, 8 Jun 2016 09:10:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08/2016 08:56 AM, Prasun Maiti wrote: > Please help me how to test this one?? It will be great to me if you help me. I do not have time or interest, sorry. You basically need access to firmware source to do any useful development on this driver in my opinion, and I do not have access to that source. Why are you so concerned about the warning anyway? Thanks, Ben > > On Wed, Jun 8, 2016 at 9:21 PM, Ben Greear wrote: >> On 06/08/2016 08:46 AM, Prasun Maiti wrote: >>> >>> Please tell me if I mention that this code is untested in commit log, >>> then could you check the code kindly and also help me to fix this type >>> of warning? >> >> >> In my experience, ath6kl has very fragile and buggy firmware, so I would >> not add any new API to it unless you have tested this thoroughly. >> >> Thanks, >> Ben >> >>> >>> On Wed, Jun 8, 2016 at 9:00 PM, Valo, Kalle >>> wrote: >>>> >>>> Prasun Maiti writes: >>>> >>>>> I am not sure it works fine. Like ath6kl driver send another cmd to >>>>> firmare, I have just filled up the cmd buffer with "tx_ant", and >>>>> "rx_ant" values, then use "ath6kl_wmi_cmd_send()" api to send the cmd >>>>> buffer to firmware. I have resend the patch as there are some errors >>>>> in the previous patch. Let me know if any modifications are needed? >>>> >>>> >>>> I don't take untested code. In some special cases it might be ok to send >>>> untested code but even then it needs to be clearly stated in the commit >>>> log that it's untested. >>>> >>>> Please resend once you have tested this, I'm dropping this now. >>>> >>>> -- >>>> Kalle Valo >>> >>> >>> >>> >> >> >> -- >> Ben Greear >> Candela Technologies Inc http://www.candelatech.com >> > > > -- Ben Greear Candela Technologies Inc http://www.candelatech.com