From: Robin Murphy <robin.murphy@arm.com>
To: Rob Herring <robh+dt@kernel.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joerg Roedel <joro@8bytes.org>, Hanjun Guo <guohanjun@huawei.com>,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Rich Felker <dalias@libc.org>, Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH v2] of: iommu: make of_iommu_init() postcore_initcall_sync
Date: Wed, 8 Jun 2016 17:48:15 +0100 [thread overview]
Message-ID: <57584C4F.6050108@arm.com> (raw)
In-Reply-To: <CAL_JsqL23AohbYhbQZyT-PRPKujttTZNNh1qdoQXv8BwyYq+mg@mail.gmail.com>
On 08/06/16 16:44, Rob Herring wrote:
> On Wed, Jun 1, 2016 at 1:06 AM, Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>> The of_iommu_init() is called multiple times by arch code,
>> make it postcore_initcall_sync, then we can drop relevant
>> calls fully.
>>
>> Note, the IOMMUs should have a chance to perform some basic
>> initialisation before we start adding masters to them. So
>> postcore_initcall_sync is good choice, it ensures of_iommu_init()
>> called before of_platform_populate.
>
> What ever happened to doing deferred probe for IOMMUs?
Sricharan has been trying to resurrect it recently[1], although the fact
that we're starting to need more or less the same thing for certain
interrupt controllers as well (and I'm not sure how immune ACPI IORT is
to the problem) suggests a more general rethink might be in order. I've
got a big TODO item hanging over me on that one...
Robin.
[1]:http://thread.gmane.org/gmane.linux.kernel.iommu/13243
>
> Rob
>
prev parent reply other threads:[~2016-06-08 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 6:06 [PATCH v2] of: iommu: make of_iommu_init() postcore_initcall_sync Kefeng Wang
2016-06-08 15:44 ` Rob Herring
2016-06-08 16:48 ` Robin Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57584C4F.6050108@arm.com \
--to=robin.murphy@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=dalias@libc.org \
--cc=guohanjun@huawei.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox