Re: [PATCH] nvmem: fix nvmem_cell_read() return type for !CONFIG_NVMEM

Brian Norris
2016-06-08T20:00:43Z

On Wed, Jun 08, 2016 at 07:52:06PM +0100, Srinivas Kandagatla wrote:
> On 08/06/16 17:40, Brian Norris wrote:
> >On Wed, Jun 08, 2016 at 09:26:46AM -0700, Brian Norris wrote:
> >>With CONFIG_NVMEM, nvmem_cell_read() returns void *. With !CONFIG_NVMEM
> >>it returns char *. Let's make that consistent. Also drop the
> >>incorrect/inconsistent comment about char * above the nvmem_cell_read()
> >>definition.
> >>
> >>drivers/thermal/mtk_thermal.c is already working around this by casting
> >>to (u32 *).
> >>
> >>Signed-off-by: Brian Norris <briannorris@chromium.org>
> >
> >Seems Guenter submitted the same thing a week ago, with no response:
>
> This patch has been already sent to Greg few days back with my sign
> off http://permalink.gmane.org/gmane.linux.kernel/2233276

Ah, didn't notice that either. Anyway, doesn't seem to show up in
linux-next.

Brian