From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933265AbcFHVv2 (ORCPT ); Wed, 8 Jun 2016 17:51:28 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34203 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933149AbcFHVv0 (ORCPT ); Wed, 8 Jun 2016 17:51:26 -0400 Subject: Re: [PATCH] Fix NFS option parsing bit-rot. To: Trond Myklebust , "linux-kernel@vger.kernel.org" , Anna Schumaker , "linux-nfs@vger.kernel.org" References: <57560021.5030708@landley.net> <575874E5.3070809@landley.net> <615FD41F-9C7D-4BAA-8BC5-D1F3CA115A8E@primarydata.com> From: Rob Landley Message-ID: <57589359.5020507@landley.net> Date: Wed, 8 Jun 2016 16:51:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <615FD41F-9C7D-4BAA-8BC5-D1F3CA115A8E@primarydata.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08/2016 03:35 PM, Trond Myklebust wrote: > > > On 6/8/16, 15:41, "Rob Landley" wrote: >>So addr= is at _best_ redundant. You MUST supply host:/ always, >>the current code just wasn't using it. > > That’s because you just happen to be supplying an IP address instead of > a hostname. The kernel has no DNS resolving functionality. It cannot > resolve hostnames into IP addresses without help either by the caller or > by means of an upcall. That is why ‘addr=’ has been a mandatory > parameter ever since we introduced the text based parser. Then why is host: mandatory in the dev name? Rob