From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426310AbcFHXJI (ORCPT ); Wed, 8 Jun 2016 19:09:08 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:32821 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423551AbcFHXJE convert rfc822-to-8bit (ORCPT ); Wed, 8 Jun 2016 19:09:04 -0400 X-AuditID: cbfee690-f79056d000001327-e5-5758a58d0373 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 8BIT Message-id: <5758A58D.7050106@samsung.com> Date: Thu, 09 Jun 2016 08:09:01 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Marc Zyngier , Kukjin Kim , Seung-Woo Kim , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, Kyungmin Park , Krzysztof Kozlowski , David Airlie , Joonyoung Shim , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800 References: <1464877210-27207-1-git-send-email-javier@osg.samsung.com> In-reply-to: <1464877210-27207-1-git-send-email-javier@osg.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsWyRsSkWLd3aUS4wec7Wha9504yWVz5+p7N 4s3bNUwWL+5dZLF4/cLQov/xa2aLs01v2C02Pb7GanF51xw2ixnn9zFZ/L3zD8ia/JLNgcdj zbw1jB6bVnWyeWz/9oDV4373cSaPzUvqPbb032X36NuyitHj8ya5AI4oLpuU1JzMstQifbsE rozT/dtZC/r5K55sc21gnMnTxcjJISFgIvGhax4bhC0mceHeeiCbi0NIYAWjRO+hXnaYokc3 VzNCJJYySvyZ9ZcRJMErICjxY/I9li5GDg5mAXWJKVNyIUwRiYbZhiAVzALaEssWvmaGaH3A KHF4ymI2kBpeAS2JHTe0QWpYBFQl5h87ygRiswHZE1fcBysRFYiQ6D5RCRIWEQiV+HfxNtgF zALtzBKX/7wFu0BYwE/i5umDLBDz5zBKHDw1kxUkwSngLnHgQQsrSEJCoJdDYu/Dq8wQ2wQk vk0+BHazhICsxKYDzBA/SkocXHGDZQKj+Cwkn81C+GwWwmezkHy2gJFlFaNoakFyQXFSepGJ XnFibnFpXrpecn7uJkZgrJ/+92zCDsZ7B6wPMQpwMCrx8GqkRIQLsSaWFVfmHmI0BbpnIrOU aHI+MKHklcQbGpsZWZiamBobmVuaKYnzvpb6GSwkkJ5YkpqdmlqQWhRfVJqTWnyIkYmDU6qB sW2noNQtyTf+kxcs+yO5/Y2IeOhU1udNhp8CJUoLNT7f+ZknI23/UVJpa2T4g9lFM29qNXiy Tu+PnpCx30RXa+Nm/t9VT+RSnU09Gxf95RT7us7Ma1ZA+8z2iuXXRNtYDBtS8p28d6+r9POt mPL8ysfVNWe794Vw2ajs/Gnz86HelTVCvJzTlFiKMxINtZiLihMBDnAFuvACAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMKsWRmVeSWpSXmKPExsVy+t9jAd3epRHhBnOuqFj0njvJZHHl63s2 izdv1zBZvLh3kcXi9QtDi/7Hr5ktzja9YbfY9Pgaq8XlXXPYLGac38dk8ffOPyBr8ks2Bx6P NfPWMHpsWtXJ5rH92wNWj/vdx5k8Ni+p99jSf5fdo2/LKkaPz5vkAjiiGhhtMlITU1KLFFLz kvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0yc4CuVVIoS8wpBQoFJBYXK+nb YZoQGuKmawHTGKHrGxIE12NkgAYS1jBm9P89yVZwlK9i57HXzA2M57m7GDk5JARMJB7dXM0I YYtJXLi3nq2LkYtDSGApo8SfWX/BErwCghI/Jt9j6WLk4GAWkJc4cikbwlSXmDIlF6L8AaPE 4SmL2UDivAJaEjtuaIN0sgioSsw/dpQJxGYDsieuuA9WIioQIdF9ohIkLCIQKvHv4m1GkDHM Au3MEpf/vAXbKizgJ3Hz9EEWiPlzGCUOnprJCpLgFHCXOPCghXUCo8AsJNfNQrhuFsJ1CxiZ VzFKpBYkFxQnpeca5qWW6xUn5haX5qXrJefnbmIEJ4hnUjsYD+5yP8QowMGoxMOrkRIRLsSa WFZcmXuIUYKDWUmE9918oBBvSmJlVWpRfnxRaU5q8SFGU6D/JjJLiSbnA5NXXkm8obGJmZGl kbmhhZGxuZI47+P/68KEBNITS1KzU1MLUotg+pg4OKUaGKdV7f14pkXuToRjzQLPaRO3TX7m 8rZsSeth6UkpdlaOOZwJ3EzBql/iRF4ckXU15e5irpr1UXum3A++i6nMO14t9Vx9qN3Fde6+ mzZ3N+5Q7zxckODzun7nW+WYwrWsRl/dv7Wa5R4JfXth3tO1dz68tVw352Gl8RnpU5dfSb5c 80NZwPlTd7MSS3FGoqEWc1FxIgBYj/ZzJgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, 2016년 06월 02일 23:20에 Javier Martinez Canillas 이(가) 쓴 글: > Commit a6f75aa161c5 ("drm/exynos: fimd: add HW trigger support") added > hardware trigger support to the FIMD controller driver. But this broke > the display in at least the Exynos5800 Peach Pi Chromebook. > > So until the issue is fixed, avoid using HW trigger for the Exynos5420 > based boards and use SW trigger as it was before the mentioned commit. > > Signed-off-by: Javier Martinez Canillas > > --- > > Hello Inki, > > Since commit a6f75aa161c5 landed in v4.7-rc1, I think $SUBJECT should be > picked to make sure that v4.7 is released with the display working for > the Exynos5420 based Chromebooks. > > We can then figure out what's wrong with the HW trigger support and fix > it for v4.8. Agree. And below is a trivial comment. > > Best regards, > Javier > > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 1c23a8ff5e83..f10030ff00e6 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -170,14 +170,11 @@ static struct fimd_driver_data exynos5420_fimd_driver_data = { > .lcdblk_vt_shift = 24, > .lcdblk_bypass_shift = 15, > .lcdblk_mic_bypass_shift = 11, > - .trg_type = I80_HW_TRG, > .has_shadowcon = 1, > .has_vidoutcon = 1, > .has_vtsel = 1, > .has_mic_bypass = 1, > .has_dp_clk = 1, > - .has_hw_trigger = 1, > - .has_trigger_per_te = 1, We don't need to remove above two lines. It would be enough to remove 'trg_type = I80_HW_TRG', which makes FIMD to be worked with SW trigger in default. Thanks, Inki Dae > }; > > struct fimd_context { >