From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425426AbcFIBSP (ORCPT ); Wed, 8 Jun 2016 21:18:15 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:44105 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423920AbcFIBSM (ORCPT ); Wed, 8 Jun 2016 21:18:12 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68e-f79b26d0000013da-6f-5758c3caf012 Content-transfer-encoding: 8BIT Message-id: <5758C3C9.4030006@samsung.com> Date: Thu, 09 Jun 2016 10:18:01 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org, wens@csie.org Cc: myungjoo.ham@samsung.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] power: axp288_charger: Replace deprecatd API of extcon References: <1464687280-8155-1-git-send-email-cw00.choi@samsung.com> <1464687280-8155-2-git-send-email-cw00.choi@samsung.com> In-reply-to: <1464687280-8155-2-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCIsWRmVeSWpSXmKPExsWyRsSkUPfU4Yhwg8OLZS0mPXnPbDFx5WRm i8u75rBZfO49wmhxu3EFm8Xp3SUWPw+dZ3Jg99jwaDWrx85Zd9k9Nq/Q8ti0qpPNo2/LKkaP z5vkAtiiuGxSUnMyy1KL9O0SuDIuPHzHXPDUpqKpsZ25gXGrURcjB4eEgInEq7eVXYycQKaY xIV769m6GLk4hARWMEp83reABSJhItE6dRkTRGIWo8SGveuZQRK8AoISPybfYwEZxCwgL3Hk UjZImFlAXWLSvEXMEPUPGCUmPL/GBlGvJTHt2il2EJtFQFXi1IbzjCA2G1B8/4sbbCBzRAUi JLpPgB0kIuAj8f3uNzaImWESHzqugK0VFgiR+Lz3JtT8y4wSP9/2M4EkOAVcJT78PguWkBC4 xi6xrv06M8QyAYlvkw+xQHwsK7HpADPEY5ISB1fcYJnAKDYLyTuzEN6ZheSdBYzMqxhFUwuS C4qT0ouM9IoTc4tL89L1kvNzNzECI+/0v2d9OxhvHrA+xCjAwajEw6uREhEuxJpYVlyZe4jR FOiIicxSosn5wPjOK4k3NDYzsjA1MTU2Mrc0UxLnTZD6GSwkkJ5YkpqdmlqQWhRfVJqTWnyI kYmDU6qBcc0iFpGrP9ylGhj4Z+V0L35g/alrZfayPyaxfzpkHq+XzHVZpSjw9/ahR1M2W/0O vnuu19XI7o6ZhnTr0atcz/8cf8JXPZuH6XR077MqntkHZ+g5Zvr8SzstHL+xa3vA1T6dhae8 vW6+u/B/Zq8Fz42p+Ut/WN4P2/fQdfOfDEfNm1xH1i6Vf67EUpyRaKjFXFScCAA1Jzp7twIA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEIsWRmVeSWpSXmKPExsVy+t9jQd1ThyPCDaauFbeY9OQ9s8XElZOZ LS7vmsNm8bn3CKPF7cYVbBand5dY/Dx0nsmB3WPDo9WsHjtn3WX32LxCy2PTqk42j74tqxg9 Pm+SC2CLamC0yUhNTEktUkjNS85PycxLt1XyDo53jjc1MzDUNbS0MFdSyEvMTbVVcvEJ0HXL zAE6RUmhLDGnFCgUkFhcrKRvh2lCaIibrgVMY4Sub0gQXI+RARpIWMOYceHhO+aCpzYVTY3t zA2MW426GDk5JARMJFqnLmOCsMUkLtxbz9bFyMUhJDCLUWLD3vXMIAleAUGJH5PvsXQxcnAw C8hLHLmUDRJmFlCXmDRvETNE/QNGiQnPr7FB1GtJTLt2ih3EZhFQlTi14TwjiM0GFN//4gYb yBxRgQiJ7hOVIGERAR+J73e/sUHMDJP40HEFbK2wQIjE5703oeZfZpT4+bYf7FBOAVeJD7/P Mk9gBLoS4bxZCOfNQnLeAkbmVYwSqQXJBcVJ6blGeanlesWJucWleel6yfm5mxjB8f1Megfj 4V3uhxgFOBiVeHg5JkeEC7EmlhVX5h5ilOBgVhLhfXwAKMSbklhZlVqUH19UmpNafIjRFOi/ icxSosn5wNSTVxJvaGxiZmRpZG5oYWRsriTO+/j/ujAhgfTEktTs1NSC1CKYPiYOTqkGRve8 l8rpFyvO9IiWKHw+IJy12u4nv1l126G5k5+/kWGf/28m9w2jJ2rbHiwTWCm9KWjiY6NCXYOb evEymkGGsVL7UyxObl+r8Jb347mw8yLP+oJqd51+mpR79CFLtfNaC22WBJ2iq007e57zNB8v U84tWf0//ekTmbIrXx4fuMvVk7rH44CHlBJLcUaioRZzUXEiAP8p/68FAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ping. Hi Sebastian, This patch just remove the deprecated extcon API without any improvement. Could you just review this patch? Thanks, Chanwoo Choi On 2016년 05월 31일 18:34, Chanwoo Choi wrote: > This patch removes the deprecated notifier API of extcon framework and then use > the new extcon API[2] with the unique id[1] to indicate the each external > connector. Alter deprecated API as following: > - extcon_register_interest() -> extcon_register_notifier() > - extcon_unregister_interest() -> extcon_unregister_notifier() > - extcon_get_cable_state() -> extcon_get_cable_state_() > > And, extcon alters the name of USB charger connector in patch[3] as following: > - EXTCON_CHG_USB_SDP /* Standard Downstream Port */ > - EXTCON_CHG_USB_DCP /* Dedicated Charging Port */ > - EXTCON_CHG_USB_CDP /* Charging Downstream Port */ > - EXTCON_CHG_USB_ACA /* Accessory Charger Adapter */ > > [1] Commit 2a9de9c0f08d61 > - ("extcon: Use the unique id for external connector instead of string) > [2] Commit 046050f6e623e4 > - ("extcon: Update the prototype of extcon_register_notifier() with enum extcon > [3] Commit 11eecf910bd81d > - ("extcon: Modify the id and name of external connector") > > Signed-off-by: Chanwoo Choi > --- > drivers/power/axp288_charger.c | 77 +++++++++++++++++++++++++++++------------- > 1 file changed, 53 insertions(+), 24 deletions(-) > > diff --git a/drivers/power/axp288_charger.c b/drivers/power/axp288_charger.c > index e4d569f57acc..4030eeb7cf65 100644 > --- a/drivers/power/axp288_charger.c > +++ b/drivers/power/axp288_charger.c > @@ -129,10 +129,6 @@ > > #define AXP288_EXTCON_DEV_NAME "axp288_extcon" > > -#define AXP288_EXTCON_SLOW_CHARGER "SLOW-CHARGER" > -#define AXP288_EXTCON_DOWNSTREAM_CHARGER "CHARGE-DOWNSTREAM" > -#define AXP288_EXTCON_FAST_CHARGER "FAST-CHARGER" > - > enum { > VBUS_OV_IRQ = 0, > CHARGE_DONE_IRQ, > @@ -158,7 +154,7 @@ struct axp288_chrg_info { > /* OTG/Host mode */ > struct { > struct work_struct work; > - struct extcon_specific_cable_nb cable; > + struct extcon_dev *cable; > struct notifier_block id_nb; > bool id_short; > } otg; > @@ -586,17 +582,15 @@ static void axp288_charger_extcon_evt_worker(struct work_struct *work) > bool old_connected = info->cable.connected; > > /* Determine cable/charger type */ > - if (extcon_get_cable_state(edev, AXP288_EXTCON_SLOW_CHARGER) > 0) { > + if (extcon_get_cable_state_(edev, EXTCON_CHG_USB_SDP) > 0) { > dev_dbg(&info->pdev->dev, "USB SDP charger is connected"); > info->cable.connected = true; > info->cable.chg_type = POWER_SUPPLY_TYPE_USB; > - } else if (extcon_get_cable_state(edev, > - AXP288_EXTCON_DOWNSTREAM_CHARGER) > 0) { > + } else if (extcon_get_cable_state_(edev, EXTCON_CHG_USB_CDP) > 0) { > dev_dbg(&info->pdev->dev, "USB CDP charger is connected"); > info->cable.connected = true; > info->cable.chg_type = POWER_SUPPLY_TYPE_USB_CDP; > - } else if (extcon_get_cable_state(edev, > - AXP288_EXTCON_FAST_CHARGER) > 0) { > + } else if (extcon_get_cable_state_(edev, EXTCON_CHG_USB_DCP) > 0) { > dev_dbg(&info->pdev->dev, "USB DCP charger is connected"); > info->cable.connected = true; > info->cable.chg_type = POWER_SUPPLY_TYPE_USB_DCP; > @@ -692,8 +686,8 @@ static int axp288_charger_handle_otg_evt(struct notifier_block *nb, > { > struct axp288_chrg_info *info = > container_of(nb, struct axp288_chrg_info, otg.id_nb); > - struct extcon_dev *edev = param; > - int usb_host = extcon_get_cable_state(edev, "USB-Host"); > + struct extcon_dev *edev = info->otg.cable; > + int usb_host = extcon_get_cable_state_(edev, EXTCON_USB_HOST); > > dev_dbg(&info->pdev->dev, "external connector USB-Host is %s\n", > usb_host ? "attached" : "detached"); > @@ -848,10 +842,33 @@ static int axp288_charger_probe(struct platform_device *pdev) > /* Register for extcon notification */ > INIT_WORK(&info->cable.work, axp288_charger_extcon_evt_worker); > info->cable.nb.notifier_call = axp288_charger_handle_cable_evt; > - ret = extcon_register_notifier(info->cable.edev, EXTCON_NONE, &info->cable.nb); > + ret = extcon_register_notifier(info->cable.edev, EXTCON_CHG_USB_SDP, > + &info->cable.nb); > + if (ret) { > + dev_err(&info->pdev->dev, > + "failed to register extcon notifier for SDP %d\n", ret); > + return ret; > + } > + > + ret = extcon_register_notifier(info->cable.edev, EXTCON_CHG_USB_CDP, > + &info->cable.nb); > + if (ret) { > + dev_err(&info->pdev->dev, > + "failed to register extcon notifier for CDP %d\n", ret); > + extcon_unregister_notifier(info->cable.edev, > + EXTCON_CHG_USB_SDP, &info->cable.nb); > + return ret; > + } > + > + ret = extcon_register_notifier(info->cable.edev, EXTCON_CHG_USB_DCP, > + &info->cable.nb); > if (ret) { > dev_err(&info->pdev->dev, > - "failed to register extcon notifier %d\n", ret); > + "failed to register extcon notifier for DCP %d\n", ret); > + extcon_unregister_notifier(info->cable.edev, > + EXTCON_CHG_USB_SDP, &info->cable.nb); > + extcon_unregister_notifier(info->cable.edev, > + EXTCON_CHG_USB_CDP, &info->cable.nb); > return ret; > } > > @@ -871,14 +888,14 @@ static int axp288_charger_probe(struct platform_device *pdev) > /* Register for OTG notification */ > INIT_WORK(&info->otg.work, axp288_charger_otg_evt_worker); > info->otg.id_nb.notifier_call = axp288_charger_handle_otg_evt; > - ret = extcon_register_interest(&info->otg.cable, NULL, "USB-Host", > + ret = extcon_register_notifier(info->otg.cable, EXTCON_USB_HOST, > &info->otg.id_nb); > if (ret) > dev_warn(&pdev->dev, "failed to register otg notifier\n"); > > - if (info->otg.cable.edev) > - info->otg.id_short = extcon_get_cable_state( > - info->otg.cable.edev, "USB-Host"); > + if (info->otg.cable) > + info->otg.id_short = extcon_get_cable_state_( > + info->otg.cable, EXTCON_USB_HOST); > > /* Register charger interrupts */ > for (i = 0; i < CHRG_INTR_END; i++) { > @@ -905,11 +922,17 @@ static int axp288_charger_probe(struct platform_device *pdev) > return 0; > > intr_reg_failed: > - if (info->otg.cable.edev) > - extcon_unregister_interest(&info->otg.cable); > + if (info->otg.cable) > + extcon_unregister_notifier(info->otg.cable, EXTCON_USB_HOST, > + &info->otg.id_nb); > power_supply_unregister(info->psy_usb); > psy_reg_failed: > - extcon_unregister_notifier(info->cable.edev, EXTCON_NONE, &info->cable.nb); > + extcon_unregister_notifier(info->cable.edev, EXTCON_CHG_USB_SDP, > + &info->cable.nb); > + extcon_unregister_notifier(info->cable.edev, EXTCON_CHG_USB_CDP, > + &info->cable.nb); > + extcon_unregister_notifier(info->cable.edev, EXTCON_CHG_USB_DCP, > + &info->cable.nb); > return ret; > } > > @@ -917,10 +940,16 @@ static int axp288_charger_remove(struct platform_device *pdev) > { > struct axp288_chrg_info *info = dev_get_drvdata(&pdev->dev); > > - if (info->otg.cable.edev) > - extcon_unregister_interest(&info->otg.cable); > + if (info->otg.cable) > + extcon_unregister_notifier(info->otg.cable, EXTCON_USB_HOST, > + &info->otg.id_nb); > > - extcon_unregister_notifier(info->cable.edev, EXTCON_NONE, &info->cable.nb); > + extcon_unregister_notifier(info->cable.edev, EXTCON_CHG_USB_SDP, > + &info->cable.nb); > + extcon_unregister_notifier(info->cable.edev, EXTCON_CHG_USB_CDP, > + &info->cable.nb); > + extcon_unregister_notifier(info->cable.edev, EXTCON_CHG_USB_DCP, > + &info->cable.nb); > power_supply_unregister(info->psy_usb); > > return 0; >