From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751767AbcFIMic (ORCPT ); Thu, 9 Jun 2016 08:38:32 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:47546 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbcFIMia (ORCPT ); Thu, 9 Jun 2016 08:38:30 -0400 X-AuditID: cbfee68f-f79d26d0000014f6-ad-5759633ea343 Message-id: <5759633E.7090706@samsung.com> Date: Thu, 09 Jun 2016 21:38:22 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Seung-Woo Kim , ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: dw_mmc: remove UBSAN warning in dw_mci_setup_bus() References: <1465358840-22826-1-git-send-email-sw0312.kim@samsung.com> In-reply-to: <1465358840-22826-1-git-send-email-sw0312.kim@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsWyRsSkQNcuOTLcoG+yuMXlXXPYLI7872e0 mDH5JZvF8bXhDiwed67tYfPo27KK0ePzJrkA5igum5TUnMyy1CJ9uwSujKbVt9gLOuUqLuxd wdjA+Feii5GTQ0LARKLj2HlGCFtM4sK99WxdjFwcQgIrGCU2XTjFDlN0+c59RojEUkaJ1oYt UM4DRon3t2exgVTxCmhJvLo+nRXEZhFQlXi76jVYN5uAjsT2b8eZQGxRgTCJB+v2skLUC0r8 mHyPBcQWEaiVeHNiKVhcWMBH4lrrZGaIBXMYJZr3vgVyODg4BdwlFt1wATGZBfQk7l/UAiln FpCX2LzmLVi5hMAydom5/zqYIW4QkPg2+RALSL2EgKzEpgPMEM9IShxccYNlAqPoLCRXzEKY OgvJ1AWMzKsYRVMLkguKk9KLjPWKE3OLS/PS9ZLzczcxAiPl9L9n/TsY7x6wPsQowMGoxMMr MCsiXIg1say4MvcQoynQEROZpUST84HxmFcSb2hsZmRhamJqbGRuaaYkzrtQ6mewkEB6Yklq dmpqQWpRfFFpTmrxIUYmDk6pBsa9dTp7tAPzmr02zO3puW/CNpezI3b7ycMNS7apGm9QmPDt b77b3Lb/Dt5Od5Ok1uxwE57sw9jlu2JpOKek/ha3I4zbW3jkZY28Qxt97R4vOdzzUU+ESeWn 67z3lR6qCxRDm1IqXskXHxdmLmNfVzs552dJbMtn797QHVISNks2qha6vOiZrcRSnJFoqMVc VJwIADPa9cCPAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsVy+t9jAV275MhwgyOHBS0u75rDZnHkfz+j xYzJL9ksjq8Nd2DxuHNtD5tH35ZVjB6fN8kFMEc1MNpkpCampBYppOYl56dk5qXbKnkHxzvH m5oZGOoaWlqYKynkJeam2iq5+AToumXmAG1TUihLzCkFCgUkFhcr6dthmhAa4qZrAdMYoesb EgTXY2SABhLWMGY0rb7FXtApV3Fh7wrGBsa/El2MnBwSAiYSl+/cZ4SwxSQu3FvP1sXIxSEk sJRRorVhCyOE84BR4v3tWWwgVbwCWhKvrk9nBbFZBFQl3q56zQ5iswnoSGz/dpwJxBYVCJN4 sG4vK0S9oMSPyfdYQGwRgVqJNyeWgsWFBXwkrrVOZoZYMIdRonnvWyCHg4NTwF1i0Q0XEJNZ QE/i/kUtkHJmAXmJzWveMk9g5J+FZOoshKpZSKoWMDKvYpRILUguKE5KzzXKSy3XK07MLS7N S9dLzs/dxAiOxmfSOxgP73I/xCjAwajEw8sxOSJciDWxrLgy9xCjBAezkgjvw4TIcCHelMTK qtSi/Pii0pzU4kOMpkBvT2SWEk3OByaKvJJ4Q2MTMyNLI3NDCyNjcyVx3sf/14UJCaQnlqRm p6YWpBbB9DFxcEo1MB7lK5s3y1fxwt+gxClZiuFNnk6c6vMO1+i/DVkikRJ81e/DPvHApVca r2zj3T3nh++nFRsbRQr+/fbKPuvwdBWjyM0dE+zF2SxSTT9mxN5oKt3wO32Dx9MooR2ynoev 7GRluL9g768w/cUFyae2n8u6/jTHi//AutAMnuPbrNWPBR68ttW7caYSS3FGoqEWc1FxIgD/ a9Ef3AIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Seung-Woo, On 06/08/2016 01:07 PM, Seung-Woo Kim wrote: > This patch removes following UBSAN warnings in dw_mci_setup_bus(). > The warnings are caused because of shift with more than 31 on 32 > bit variable, so this patch fixes to shift only for less than 32. > > UBSAN: Undefined behaviour in drivers/mmc/host/dw_mmc.c:1102:14 > shift exponent 250 is too large for 32-bit type 'unsigned int' > Call trace: > [] dump_backtrace+0x0/0x380 > [] show_stack+0x14/0x20 > [] dump_stack+0xe0/0x120 > [] ubsan_epilogue+0x18/0x68 > [] __ubsan_handle_shift_out_of_bounds+0x18c/0x1bc > [] dw_mci_setup_bus+0x3a0/0x438 > [...] > > UBSAN: Undefined behaviour in drivers/mmc/host/dw_mmc.c:1132:27 > shift exponent 250 is too large for 32-bit type 'unsigned int' > Call trace: > [] dump_backtrace+0x0/0x380 > [] show_stack+0x14/0x20 > [] dump_stack+0xe0/0x120 > [] ubsan_epilogue+0x18/0x68 > [] __ubsan_handle_shift_out_of_bounds+0x18c/0x1bc > [] dw_mci_setup_bus+0x384/0x438 The below message can be discarded. > [] dw_mci_set_ios+0x184/0x798 > [] mmc_power_up+0x11c/0x260 > [] mmc_start_host+0x88/0x100 > [] mmc_add_host+0x6c/0x128 > [] dw_mci_probe+0x1088/0x1750 > [] dw_mci_pltfm_register+0x108/0x178 > [] dw_mci_exynos_probe+0x4c/0x88 > [] platform_drv_probe+0x78/0x180 > [] driver_probe_device+0x144/0x460 > [] __driver_attach+0xf4/0x140 > [] bus_for_each_dev+0xf0/0x160 > [] driver_attach+0x34/0x58 > [] bus_add_driver+0x2c0/0x398 > [] driver_register+0xbc/0x1e0 > [] __platform_driver_register+0x84/0xa8 > [] dw_mci_exynos_pltfm_driver_init+0x18/0x20 > [] do_one_initcall+0xa0/0x2c8 > [] kernel_init_freeable+0x52c/0x5dc > [] kernel_init+0x1c/0xf8 > [] ret_from_fork+0x10/0x40 > > Signed-off-by: Seung-Woo Kim > --- > drivers/mmc/host/dw_mmc.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 2cc6123..dff045e 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -1099,7 +1099,8 @@ static void dw_mci_setup_bus(struct dw_mci_slot *slot, bool force_clkinit) > > div = (host->bus_hz != clock) ? DIV_ROUND_UP(div, 2) : 0; > > - if ((clock << div) != slot->__clk_old || force_clkinit) > + if (((div < 32) ? (clock << div) : 0) != slot->__clk_old || Well, we don't expect that clock is 0. if clock is 0, it should be passed to " if (!clock)".. During initializing card, clock is 400KHz or less..I understood what you want to fix. But I taught this is not correct. > + force_clkinit) > dev_info(&slot->mmc->class_dev, > "Bus speed (slot %d) = %dHz (slot req %dHz, actual %dHZ div = %d)\n", > slot->id, host->bus_hz, clock, > @@ -1129,7 +1130,7 @@ static void dw_mci_setup_bus(struct dw_mci_slot *slot, bool force_clkinit) > mci_send_cmd(slot, sdmmc_cmd_bits, 0); > > /* keep the clock with reflecting clock dividor */ > - slot->__clk_old = clock << div; > + slot->__clk_old = (div < 32) ? (clock << div) : 0; Also, clock is not 0.. Best Regards, Jaehoon Chung > } > > host->current_speed = clock; >