From: Andrey Ryabinin <aryabinin@virtuozzo.com>
To: Kuthonuzo Luruo <kuthonuzo.luruo@hpe.com>, <glider@google.com>,
<dvyukov@google.com>, <cl@linux.com>, <penberg@kernel.org>,
<rientjes@google.com>, <iamjoonsoo.kim@lge.com>,
<akpm@linux-foundation.org>
Cc: <kasan-dev@googlegroups.com>, <linux-kernel@vger.kernel.org>,
<ynorov@caviumnetworks.com>
Subject: Re: [PATCH v5 1/2] mm, kasan: improve double-free detection
Date: Thu, 9 Jun 2016 20:00:25 +0300 [thread overview]
Message-ID: <5759A0A9.3080301@virtuozzo.com> (raw)
In-Reply-To: <20160607180322.GA1782@cherokee.in.rdlabs.hpecorp.net>
On 06/07/2016 09:03 PM, Kuthonuzo Luruo wrote:
Next time, when/if you send patch series, send patches in one thread, i.e. patches should be replies to the cover letter.
Your patches are not linked together, which makes them harder to track.
> Currently, KASAN may fail to detect concurrent deallocations of the same
> object due to a race in kasan_slab_free(). This patch makes double-free
> detection more reliable by serializing access to KASAN object metadata.
> New functions kasan_meta_lock() and kasan_meta_unlock() are provided to
> lock/unlock per-object metadata. Double-free errors are now reported via
> kasan_report().
>
> Per-object lock concept from suggestion/observations by Dmitry Vyukov.
>
So, I still don't like this, this too way hacky and complex.
I have some thoughts about how to make this lockless and robust enough.
I'll try to sort this out tomorrow.
next prev parent reply other threads:[~2016-06-09 16:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 18:03 [PATCH v5 1/2] mm, kasan: improve double-free detection Kuthonuzo Luruo
2016-06-09 13:32 ` Alexander Potapenko
2016-06-09 16:54 ` Luruo, Kuthonuzo
2016-06-09 17:00 ` Andrey Ryabinin [this message]
2016-06-10 17:03 ` Andrey Ryabinin
2016-06-10 17:09 ` Dmitry Vyukov
2016-06-15 16:18 ` Andrey Ryabinin
2016-06-13 11:56 ` Alexander Potapenko
2016-06-14 6:46 ` Luruo, Kuthonuzo
2016-06-15 16:38 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5759A0A9.3080301@virtuozzo.com \
--to=aryabinin@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kasan-dev@googlegroups.com \
--cc=kuthonuzo.luruo@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=ynorov@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox