From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933183AbcFISLb (ORCPT ); Thu, 9 Jun 2016 14:11:31 -0400 Received: from mail-bn1bon0081.outbound.protection.outlook.com ([157.56.111.81]:62544 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932237AbcFISLY (ORCPT ); Thu, 9 Jun 2016 14:11:24 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=David.Daney@cavium.com; Message-ID: <5759B143.9070503@caviumnetworks.com> Date: Thu, 9 Jun 2016 11:11:15 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Marc Zyngier CC: Daniel Lezcano , Thomas Gleixner , Rob Herring , Mark Rutland , Andrew Lunn , Krzysztof Kozlowski , Liu Gang , Masahiro Yamada , Florian Fainelli , Kevin Hilman , Hou Zhiqiang , Michal Simek , Kukjin Kim , , , Sebastian Hesselbarth , Jason Cooper , Ray Jui , Tirumalesh Chalamarla , , Yuan Yao , Wenbin Song , Jan Glauber , Gregory Clement , , Mingkai Hu , =?ISO-8859-1?Q?S=F6ren_Brinkmann?= , Rajesh Bhagat , Scott Branden , Duc Dang , , Carlo Caione , Dinh Nguyen Subject: Re: [PATCH v3 2/2] arm64: dts: Fix broken architected timer interrupt trigger References: <1465235791-7064-1-git-send-email-marc.zyngier@arm.com> <1465235791-7064-3-git-send-email-marc.zyngier@arm.com> In-Reply-To: <1465235791-7064-3-git-send-email-marc.zyngier@arm.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [50.233.148.158] X-ClientProxiedBy: BY2PR07CA0095.namprd07.prod.outlook.com (10.166.107.48) To CY1PR07MB2134.namprd07.prod.outlook.com (10.164.112.12) X-MS-Office365-Filtering-Correlation-Id: 6c158d88-78ed-4382-23de-08d39091753a X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2134;2:FS9mW1FGA6IeSYqjeLpVdPDF3YAgyYOatrF88HcaphfQ+TWjroMWT1ufZMTNJUuIjPdbXjvgmEM0oH1tEDy5LYISHaVziV4An62rtJUQ7IzcRKqox+SJzheiSYpSbLy01Ds9Y2EGI27Vst+Frx7TK/1L8JcfjTy1deLdLRRhKFjhqu0WxchSNPMX8dzqLVJb;3:i+YDyNwrlT7oT2pQl2EtF/5t4+6sG4iC33PsT3CiXO+IgQmJjmzlYkW4jbGbkrDUteOcJ6pM22C6ax4H/bEYdumP4gfLm89bjAgTTOSzlPFEg8OpIQxW4p29BS+UnziO;25:jR3qjsLsEoXhxgvptRhn09EiFNYVDJaqkwqvDJPfLtNOH9iGg/J5C97dkkZG+dgmMRnxfVadKkSFO3bQWvVjMN1vShdZ1zoHAji2WlsoNFN9FzOT9LtrUxTVn1r6K8drnzV5vyCQDjDWjko2GlKc2hGdpO9zrxgYveIL5qOXVRcFbg8KTz/oAMmaqsxZiDAX4RZBJ3SEEUMIYp0btCd8oRIOPFnQ1fuNeLiMTY2i8IsXEjaK0HiDfkzO5F0B81EbBxKmnWBgzGPW7W8lbmN9NwnaurQPa3/rjr5zVGQlC2yudnnH7Y7md7DHGEfblY81+nJQj0d1y3/OcT6/b1c4R1nu6UTcAZllIOWupO4FAcp+uqcwMIRES/4kxS2WY89ZDCVRK/ZQsMNv5ENd2qUqhUQ4k/ckbrWymSuN+ermQyo= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2134; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2134;20:0CztVuad6grtZ3QJkacj7Q3Zu78lKcbDU2/esNahoedNTYQUrNbF7ZgeeNn2UEs6dmoFYej36B5PXR0pmqaOjBV0/pN0JbrHnJ+hZzIB1k3pBaO9Y1TVtwwC2EHLz5Ivgn7HB4oKyiuI8sycrRKSSQ9JNBduzzDIDWPdTv3nFe7pdUIXQV0/JWFyjwS3DCydYIL4nWsHN+G0RPCezeIE4mn54cckdh+U7ejlkEVb55LpXkabdIJTndYwTP+lIathFvXECKozGWh9IxDRpawEb4hg2n9QC8PJBKhCz6iEjaFDOWA3c8N147uMxvHfsBJ1xj5/zjNRHYl37OMeiknuRO5k1rxles/uSdf6gKFUuD0gPyGHKI/DD+Laq/u+RsAoAVSp3d+sIgRdX1J44rztUf28oApMzlV67eBUkJd7raXjqODHlAGgxMEWR9uIAeBOvgxlKMewWGNZZkc5EFapXDkf7SSVuS/cJpK85lUtGJCm/xmk4omW1n37uZkOwbQ475pQh38vjF8QhkHKIiQqg6EM06oSBTh7fQ/pp99XeIqfuv6MY0lmzClPkSRW6OnfSRSXSKhVG8vlKLted1niCJIELea+6U+iOeEv3tCQIlM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:CY1PR07MB2134;BCL:0;PCL:0;RULEID:;SRVR:CY1PR07MB2134; X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2134;4:o16idQ0m43J8Q8x3yLytWJ23TLHj5hfDMCDBOWAdSqmbL+7TSRU5s3Hxd/U/9cM0fO/fl3rSTJVNt/KSHq+87GxpfRxurRxkp57SfVadYUSDaxcmnCmcnxJyr+5+YQIt72ibkw2NzstN1Hmpb0pnvefsdGGHOSj+XB3SWUoh+uqO/USW3IRwFfwzSChxlmyZZ48hJJlERVNbI8T86w/3J1SRfPyZ8z4HI8Twt5PuBxILzgah6aq3sgzJVGG5Bp8JVU0qAZzFlsmpnK72A0tz31NdFQqAtaAAINZy70kwntjh5PpoIero7YFtx8Y6PK6iYfWpu7KofdGavrdJf76LocuSqtTV/XCL/C9pyzZDUH48OmIbR6THprxSoOKfzc3ztdqA7gcddgJ98keX+OULymJFeN0tj7dUoTCHt+gfXUc= X-Forefront-PRVS: 0968D37274 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(377454003)(189002)(199003)(24454002)(5008740100001)(106356001)(2906002)(230700001)(4001350100001)(97736004)(33656002)(105586002)(50466002)(42186005)(50986999)(80316001)(36756003)(110136002)(76176999)(189998001)(19580405001)(65816999)(68736007)(101416001)(54356999)(69596002)(4326007)(19580395003)(65956001)(92566002)(81166006)(8666004)(65806001)(53416004)(87266999)(81156014)(47776003)(586003)(66066001)(2950100001)(64126003)(83506001)(77096005)(59896002)(3846002)(8676002)(5004730100002)(6116002)(23756003)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR07MB2134;H:dl.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;CY1PR07MB2134;23:4oAWWLQbSYq4k6h4Jr/Pj1s4zA8wUzdBE9izoXq?= =?iso-8859-1?Q?8qcU5MlATe7esUCWDeoIyzJMnm1Z8DrT2T7oB7UcfxWT7s9ITsN+03wHvp?= =?iso-8859-1?Q?FEduFNZpr3Ko+ie/5yKbCMtPMq9dwt7P0nNUM/S4XTbhtlpnh9/JHeU+91?= =?iso-8859-1?Q?ccM5Cd5zUqNyvDYuHkjoZYheDKnfWkWFmTFXHnPs+jyvZFQ80ZIEWyzWIT?= =?iso-8859-1?Q?lN9aGEN42EO3nQ9AejSCLcTelebxoZ2x29ehJrci/AOQizk0Gk8xHy7jGu?= =?iso-8859-1?Q?sTpsGGQjfQCfGHDAqXYsWG7jm3xdzHimYU1F8AhI/VFLD8+RxJgG9VS0wo?= =?iso-8859-1?Q?4HTEnqjwT/OCMYNs9mCw4YsYpV6OU1/9e06VsQvp/zXVMzLGi+pvadvEQS?= =?iso-8859-1?Q?Un82fkTohFgrGBcuSwyNItT/i7I5QoWXinDF6YEiL+oxALywlJXZNMzRPg?= =?iso-8859-1?Q?hQJQa11rtUhWFUp1BRqbasaGucZBCfjFVKgEzdhdxFNKqFYU+LxK9hgOAL?= =?iso-8859-1?Q?hYaxA3nIIz6cKCwH/UO0Kcq6h/ZmGfmH+4Xsw1YXvdoza09the6S6aGBcF?= =?iso-8859-1?Q?OX9wlKTJ77tcZos1FpeW6sa81qdnRXCWNHkxQPt7N0EpcULArp6Kbg0lYj?= =?iso-8859-1?Q?umm8d3DVqEo2+fKwWZHDRe47t3+Q9ozRTjsAxhotBFqDxL5YLRyJQr8kp0?= =?iso-8859-1?Q?WCW/s2zcFPvilEvh5SxJOfXh4SOnxB1lVhye2x3ZgtKmo7lI3cz7aOEuT7?= =?iso-8859-1?Q?+iGxXb4yprW/Vmm4hC8ZTIafZlMbsHPJTKTIy0g4TIqb0AoC85ZOHJvbBD?= =?iso-8859-1?Q?8y6KOvJbYor0LU8vVRAiUBvYdPvBr+461NA5axpqQK23XAuN3xNLvBrwZq?= =?iso-8859-1?Q?5qI32bDKmYFBlyMznM0NdJi3/HlxJjCLUTmgHrKVZZcry+0IXcCbNJDEJI?= =?iso-8859-1?Q?LebDjXj67bcmVLV9Ed5R6cTibKknc04gmfBxw6r8IIRZ9NJb/CVwmrO0Rc?= =?iso-8859-1?Q?ldRpL5i3R2LvULXL8N/tgN3VuHrv7AvkVEBxQ9F4XsQAn6xJxyDnaff/ig?= =?iso-8859-1?Q?9r1G1P8X6f9QKMEn+X0KFirKkq1v1RjXFkc+H97Gc6dZpbvpUkx/qSm2Oi?= =?iso-8859-1?Q?YAckF5xyDYe+RERo7UZ/2YoZD+oNgBScoCn3VJ7oeMe3pK3vMPG+7mb7RG?= =?iso-8859-1?Q?U+RlZFs73SSSmoO3ImDlm8T8Q3VDg7RVL8pn1zR7yU2stjzzPWyE4WiRYW?= =?iso-8859-1?Q?o0BuSkR9kKwee4UlPO/5Fenrx6HGLHSw8qqOn6RZ1zeNBqJIcjmW+xt/Yt?= =?iso-8859-1?Q?CM1dLHv4vaMviDlmJbg8W+WpPiFtEYxP00U4Z5r8aekplS9C9FgPjU/pZJ?= =?iso-8859-1?Q?ZTHJHOyw=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR07MB2134;5:qvNnAUlIqSKf/uHFwb0a6dbK8QKeMKuY58EHIwi95Wh3Dn5+2C5dK0+VAitfvjLfNRlru66GKtj/cuXNVAwuFpJVQwiA8jTeLbNOb1hzXUBjwIHoC4gC4HHN7VRoiMxo8O3sAnTDJ/jqofeTSGp1tw==;24:VG6swtwdnoB6aC5OwXKiRsZZ99JktqV3/ruhP8+xVwW5LBOGALh3C1zIDQh1+jwDdlc8wv3SKxcGWZRNvUeOBpoMNSsZQs55nV/yfyCOFJI=;7:rh4D2WiMydeuY1atc4/nh0C5n2EjsHnCjbSnmG38f1WWFC6MBeFqQ0U17N2PVcv6YNr/rq0g+ilxPzkLXhro3RIc74/DPfdK3MmUydUhZIhBKono0+J9sB3Lt/9ETifyUCzah2bP5/XdXXzo+6kdFj+Vr1TUzc4VGpVk+K8epJrdH7OY0k3Qsbl0+Nky55ryWrjw6JQkLB4dnksyPlDKgIXmOuuEa31dxxTsGJiheSU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2016 18:11:18.8163 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2134 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/06/2016 10:56 AM, Marc Zyngier wrote: > The ARM architected timer specification mandates that the interrupt > associated with each timer is level triggered (which corresponds to > the "counter >= comparator" condition). > > A number of DTs are being remarkably creative, declaring the interrupt > to be edge triggered. A quick look at the TRM for the corresponding ARM > CPUs clearly shows that this is wrong, and I've corrected those. > For non-ARM designs (and in the absence of a publicly available TRM), > I've made them active low as well, which can't be completely wrong > as the GIC cannot disinguish between level low and level high. > > The respective maintainers are of course welcome to prove me wrong. > > While I was at it, I took the liberty to fix a couple of related issue, > such as some spurious affinity bits on ThunderX, and their complete > absence on ls1043a (both of which seem to be related to copy-pasting > from other DTs). > > Signed-off-by: Marc Zyngier > --- > arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi | 8 ++++---- > arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 8 ++++---- > arch/arm64/boot/dts/apm/apm-storm.dtsi | 8 ++++---- > arch/arm64/boot/dts/broadcom/ns2.dtsi | 8 ++++---- > arch/arm64/boot/dts/cavium/thunder-88xx.dtsi | 8 ++++---- > arch/arm64/boot/dts/exynos/exynos7.dtsi | 8 ++++---- > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 8 ++++---- > arch/arm64/boot/dts/marvell/armada-ap806.dtsi | 8 ++++---- > arch/arm64/boot/dts/socionext/uniphier-ph1-ld20.dtsi | 8 ++++---- > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 8 ++++---- > 10 files changed, 40 insertions(+), 40 deletions(-) > [...] > diff --git a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > index 2eb9b22..382d86f 100644 > --- a/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > +++ b/arch/arm64/boot/dts/cavium/thunder-88xx.dtsi > @@ -354,10 +354,10 @@ > > timer { > compatible = "arm,armv8-timer"; > - interrupts = <1 13 0xff01>, > - <1 14 0xff01>, > - <1 11 0xff01>, > - <1 10 0xff01>; > + interrupts = <1 13 8>, > + <1 14 8>, > + <1 11 8>, > + <1 10 8>; > }; > > pmu { Acked-by: David Daney