From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751758AbcFJAvx (ORCPT ); Thu, 9 Jun 2016 20:51:53 -0400 Received: from regular1.263xmail.com ([211.150.99.139]:38999 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbcFJAvw (ORCPT ); Thu, 9 Jun 2016 20:51:52 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: wxt@rock-chips.com X-FST-TO: computersforpeace@gmail.com X-SENDER-IP: 58.22.64.175 X-LOGIN-NAME: wxt@rock-chips.com X-UNIQUE-TAG: <203a93577675a9c6dc04b62cf0a1b546> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] drm/rockchip: fix compile warnings for 64-bit To: Brian Norris , Mark Yao References: <1465494392-92489-1-git-send-email-briannorris@chromium.org> Cc: Heiko Stuebner , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Brian Norris From: Caesar Wang Message-ID: <575A0F19.1040609@rock-chips.com> Date: Fri, 10 Jun 2016 08:51:37 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1465494392-92489-1-git-send-email-briannorris@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016年06月10日 01:46, Brian Norris 写道: > Rockchip DRM does not yet build properly for ARM64, but we might as well > get the printf formatting correct now, to avoid the following warnings: > > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c: In function 'rockchip_drm_fbdev_create': > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c:111:2: warning: format '%d' expects argument of type 'int', but argument 8 has type 'size_t' [-Wformat=] > DRM_DEBUG_KMS("FB [%dx%d]-%d kvaddr=%p offset=%ld size=%d\n", > ^ > > drivers/gpu/drm/rockchip/rockchip_drm_gem.c: In function 'rockchip_gem_alloc_buf': > drivers/gpu/drm/rockchip/rockchip_drm_gem.c:41:3: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'size_t' [-Wformat=] > DRM_ERROR("failed to allocate %#x byte dma buffer", obj->size); > ^ > > Signed-off-by: Brian Norris Tested-by: Caesar Wang > --- > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c | 2 +- > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c > index f261512bb4a0..bab4cd18b6b0 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.c > @@ -108,7 +108,7 @@ static int rockchip_drm_fbdev_create(struct drm_fb_helper *helper, > fbi->screen_size = rk_obj->base.size; > fbi->fix.smem_len = rk_obj->base.size; > > - DRM_DEBUG_KMS("FB [%dx%d]-%d kvaddr=%p offset=%ld size=%d\n", > + DRM_DEBUG_KMS("FB [%dx%d]-%d kvaddr=%p offset=%ld size=%zu\n", > fb->width, fb->height, fb->depth, rk_obj->kvaddr, > offset, size); > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > index 9c2d8a894093..059e902f872d 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > @@ -38,7 +38,7 @@ static int rockchip_gem_alloc_buf(struct rockchip_gem_object *rk_obj, > &rk_obj->dma_addr, GFP_KERNEL, > &rk_obj->dma_attrs); > if (!rk_obj->kvaddr) { > - DRM_ERROR("failed to allocate %#x byte dma buffer", obj->size); > + DRM_ERROR("failed to allocate %zu byte dma buffer", obj->size); > return -ENOMEM; > } >