Re: [PATCH v2] ARM64: boot: dts: Add regulators for Tegra210 Smaug

[Laxman Dewangan <ldewangan@nvidia.com>]

On Thursday 09 June 2016 11:08 PM, Rhyland Klein wrote:
> Add regulators to the Tegra210 Smaug DTS file including
> support for the max77620 PMIC.
>
> Signed-off-by: Rhyland Klein <rklein@nvidia.com>
>
> +
> +				fps1 {
> +					maxim,shutdown-fps-time-period-us = <5120>;
> +					maxim,fps-event-source = <MAX77620_FPS_EVENT_SRC_EN1>;
> +					maxim,enable-sleep;
The maxim,enabel-sleep is not the valid property.
It should be
maxim,device-state-on-disabled-event = <MAX77620_FPS_INACTIVE_STATE_SLEEP>;



> +				};
> +
> +				fps2 {
> +					maxim,fps-event-source = <MAX77620_FPS_EVENT_SRC_EN0>;
> +				};
> +			};
> +
> +			regulators {
> +				in-ldo0-1-supply = <&pp1350>;
> +				in-ldo2-supply = <&pp3300>;
> +				in-ldo3-5-supply = <&pp3300>;
> +				in-ldo7-8-supply = <&pp1350>;
> +
> +				ppvar_soc: sd0 {
> +					regulator-name = "PPVAR_SOC";
> +					regulator-min-microvolt = <825000>;
> +					regulator-max-microvolt = <1125000>;
> +					regulator-enable-ramp-delay = <146>;
> +					regulator-always-on;
> +					regulator-boot-on;
> +					maxim,ramp-rate-setting = <27500>;
You need to say regulator-ramp-delay if register config is same as what 
platform observed.
This is applicable for all places.


> +			regulator-always-on;
> +			gpio = <&max77620 3 0>;
GPIO3 is fps-out and hence it can not be done here. Better to do not 
provide any gpio entry.