From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752873AbcFJGlN (ORCPT <rfc822;w@1wt.eu>);
	Fri, 10 Jun 2016 02:41:13 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:18106 "EHLO
	hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751383AbcFJGlK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Jun 2016 02:41:10 -0400
X-PGP-Universal: processed;
	by hqnvupgp08.nvidia.com on Thu, 09 Jun 2016 23:38:44 -0700
Message-ID: <575A5DFD.6040300@nvidia.com>
Date: Fri, 10 Jun 2016 11:58:13 +0530
From: Laxman Dewangan <ldewangan@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Rhyland Klein <rklein@nvidia.com>,
        Thierry Reding <thierry.reding@gmail.com>
CC: Stephen Warren <swarren@wwwdotorg.org>, Jon Hunter <jonathanh@nvidia.com>,
        Alexandre Courbot <gnurou@gmail.com>,
        Andrew Bresticker <abrestic@chromium.org>,
        <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] ARM64: boot: dts: Add regulators for Tegra210 Smaug
References: <1465493923-23313-1-git-send-email-rklein@nvidia.com>
In-Reply-To: <1465493923-23313-1-git-send-email-rklein@nvidia.com>
X-Originating-IP: [10.19.65.30]
X-ClientProxiedBy: BGMAIL103.nvidia.com (10.25.59.12) To bgmail102.nvidia.com
 (10.25.59.11)
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Thursday 09 June 2016 11:08 PM, Rhyland Klein wrote:
> Add regulators to the Tegra210 Smaug DTS file including
> support for the max77620 PMIC.
>
> Signed-off-by: Rhyland Klein <rklein@nvidia.com>
>
> +
> +				fps1 {
> +					maxim,shutdown-fps-time-period-us = <5120>;
> +					maxim,fps-event-source = <MAX77620_FPS_EVENT_SRC_EN1>;
> +					maxim,enable-sleep;
The maxim,enabel-sleep is not the valid property.
It should be
maxim,device-state-on-disabled-event = <MAX77620_FPS_INACTIVE_STATE_SLEEP>;



> +				};
> +
> +				fps2 {
> +					maxim,fps-event-source = <MAX77620_FPS_EVENT_SRC_EN0>;
> +				};
> +			};
> +
> +			regulators {
> +				in-ldo0-1-supply = <&pp1350>;
> +				in-ldo2-supply = <&pp3300>;
> +				in-ldo3-5-supply = <&pp3300>;
> +				in-ldo7-8-supply = <&pp1350>;
> +
> +				ppvar_soc: sd0 {
> +					regulator-name = "PPVAR_SOC";
> +					regulator-min-microvolt = <825000>;
> +					regulator-max-microvolt = <1125000>;
> +					regulator-enable-ramp-delay = <146>;
> +					regulator-always-on;
> +					regulator-boot-on;
> +					maxim,ramp-rate-setting = <27500>;
You need to say regulator-ramp-delay if register config is same as what 
platform observed.
This is applicable for all places.


> +			regulator-always-on;
> +			gpio = <&max77620 3 0>;
GPIO3 is fps-out and hence it can not be done here. Better to do not 
provide any gpio entry.