From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752842AbcFJJHP (ORCPT <rfc822;w@1wt.eu>);
	Fri, 10 Jun 2016 05:07:15 -0400
Received: from out1134-235.mail.aliyun.com ([42.120.134.235]:65204 "EHLO
	out1134-235.mail.aliyun.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751698AbcFJJHJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Jun 2016 05:07:09 -0400
X-Greylist: delayed 304 seconds by postgrey-1.27 at vger.kernel.org; Fri, 10 Jun 2016 05:07:08 EDT
X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07530651|-1;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03290;MF=chengang@emindsoft.com.cn;NM=1;PH=DS;RN=13;RT=13;SR=0;TI=SMTPD_----4udpvrY_1465549308;
Message-ID: <575A836A.5000606@emindsoft.com.cn>
Date: Fri, 10 Jun 2016 17:07:54 +0800
From: Chen Gang <chengang@emindsoft.com.cn>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: kbuild test robot <lkp@intel.com>
CC: kbuild-all@01.org, akpm@linux-foundation.org, trivial@kernel.org,
        mhocko@suse.cz, dan.j.williams@intel.com, iamjoonsoo.kim@lge.com,
        vbabka@suse.cz, baiyaowei@cmss.chinamobile.com, vkuznets@redhat.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Chen Gang <gang.chen.5i5j@gmail.com>
Subject: Re: [PATCH trivial] include/linux/memory_hotplug.h: Clean up code
References: <201606101451.xfKpSBrt%fengguang.wu@intel.com>
In-Reply-To: <201606101451.xfKpSBrt%fengguang.wu@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/10/16 14:11, kbuild test robot wrote:
> Hi,
> 
> [auto build test ERROR on next-20160609]
> [also build test ERROR on v4.7-rc2]
> [cannot apply to v4.7-rc2 v4.7-rc1 v4.6-rc7]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 

Oh, my patch is for linux-next 20160609 tree, can not apply to v4.7-rc2
directly.

[...]

> 
>    In file included from include/linux/mmzone.h:741:0,
>                     from include/linux/gfp.h:5,
>                     from include/linux/kmod.h:22,
>                     from include/linux/module.h:13,
>                     from include/linux/moduleloader.h:5,
>                     from arch/blackfin/kernel/module.c:9:
>    include/linux/memory_hotplug.h: In function 'mhp_notimplemented':
>>> include/linux/memory_hotplug.h:225:2: error: 'mod' undeclared (first use in this function)
>    include/linux/memory_hotplug.h:225:2: note: each undeclared identifier is reported only once for each function it appears in
> 
> vim +/mod +225 include/linux/memory_hotplug.h
> 
>    219	static inline void zone_span_writelock(struct zone *zone) {}
>    220	static inline void zone_span_writeunlock(struct zone *zone) {}
>    221	static inline void zone_seqlock_init(struct zone *zone) {}
>    222	
>    223	static inline int mhp_notimplemented(const char *func)
>    224	{
>  > 225		pr_warn("%s() called, with CONFIG_MEMORY_HOTPLUG disabled\n", func);
>    226		dump_stack();
>    227		return -ENOSYS;
>    228	}
> 

After "grep -rn pr_fmt * | grep define" under arch/, for me, it is
blackfin's issue:

  we need use

    #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

  instead of

    #define pr_fmt(fmt) "module %s: " fmt, mod->name

I shall send one blackfin patch for it.

Thanks.
-- 
Chen Gang (陈刚)

Managing Natural Environments is the Duty of Human Beings.