From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932798AbcFJKXx (ORCPT ); Fri, 10 Jun 2016 06:23:53 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:16424 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161024AbcFJKXu (ORCPT ); Fri, 10 Jun 2016 06:23:50 -0400 X-AuditID: cbfec7f5-f792a6d000001302-6e-575a953275af Subject: Re: [PATCH 1/2] max8903: adds support for initiation via device tree. To: chris@lapa.com.au References: <1464849897-21527-1-git-send-email-chris@lapa.com.au> <1464849897-21527-2-git-send-email-chris@lapa.com.au> <98c757cd-d1b4-1599-ebb3-2a9cc3fc478d@lapa.com.au> <575A5A88.3070404@samsung.com> Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Krzysztof Kozlowski Message-id: <575A9532.6080005@samsung.com> Date: Fri, 10 Jun 2016 12:23:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <575A5A88.3070404@samsung.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHLMWRmVeSWpSXmKPExsVy+t/xq7pGU6PCDU7Os7F4eMbM4vULQ4vL u+awWXzuPcLowOKxbO5mRo++LasYPT5vkgtgjuKySUnNySxLLdK3S+DKeHjsJnPBRNaK+VO/ sTcwNrN0MXJySAiYSMxr38EMYYtJXLi3nq2LkYtDSGApo8TfQ88YQRJCAs8YJaYu1u5i5OAQ FvCT+DgVLCwiICrx8+9mdoj6aUwS02c3sIEkmAWsJHY96gMrYhMwlti8fAlYnFdAS+JnC0gD JweLgKpE37mjYEeICkRIzNr+gwmiRlDix+R7YHFOAW2J5j1n2UD2MguoS0yZkgsxXl5i85q3 zBMYBWYh6ZiFUDULSdUCRuZVjKKppckFxUnpuUZ6xYm5xaV56XrJ+bmbGCGh+nUH49JjVocY BTgYlXh4I3ZFhguxJpYVV+YeYpTgYFYS4X03KSpciDclsbIqtSg/vqg0J7X4EKM0B4uSOO/M Xe9DhATSE0tSs1NTC1KLYLJMHJxSDYwnc1I2W3340OodMfvR/a+Hc0++aSjXywudZmsWKJzn V3CNW/nujKtSVrtMJLZ4ztTtenrt6efnswJ/tkqXrdryebPtd67lnocDp9geqrJbKxBqvfB4 vFL/m993vEssforVJqvPaSzdcMWMaWK2wsy+N/pMelLRJ16n3fftrVviZ8wY/P5/jJcSS3FG oqEWc1FxIgAVjb8jUQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/2016 08:13 AM, Krzysztof Kozlowski wrote: > On 06/10/2016 07:35 AM, Chris Lapa wrote: >> Hi Krzysztof, >> >> Thanks for the review. I'm working on those changes now. >> >> However just so I know for the future. Why no error checking on >> devm_kzalloc() result? Looking through the source for devm_kzalloc() it >> looks like NULL isn't caught anywhere else. > > Error checking is necessary. Just do not print the error message. The > kernel core will print one with full back trace. > > if (charger == NULL) > return -ENOMEM; ... and while at it just convert it to simpler: if (!charger) return -ENOMEM; BR, Krzysztof