From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932914AbcFJNvm (ORCPT ); Fri, 10 Jun 2016 09:51:42 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:56402 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932124AbcFJNvj (ORCPT ); Fri, 10 Jun 2016 09:51:39 -0400 X-AuditID: cbfec7f5-f792a6d000001302-8b-575ac5e785aa Subject: Re: [PATCH v2 1/4] max8903: adds documentation for device tree bindings. To: Chris Lapa References: <1464849897-21527-3-git-send-email-chris@lapa.com.au> <1465561970-18377-1-git-send-email-chris@lapa.com.au> <1465561970-18377-2-git-send-email-chris@lapa.com.au> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <575AC5E5.3020405@samsung.com> Date: Fri, 10 Jun 2016 15:51:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1465561970-18377-2-git-send-email-chris@lapa.com.au> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsVy+t/xa7rPj0aFG9w5Jmbx8IyZxfwj51gt Xr8wtLi8aw6bxefeI4wOrB7L5m5m9OjbsorR4/MmuQDmKC6blNSczLLUIn27BK6MvTv/MhU0 ilY8PrSesYFxtWAXIweHhICJxJk7nF2MnECmmMSFe+vZQGwhgaWMEps2M3cxcgHZzxglrp54 zwqSEBYIlnjxZDkTiC0ioCTRcXshC0TRRkaJdRubwLqZBSIkOh8cYgex2QSMJTYvX8IGsUFO ord7EgvIYl4BLYmZN8AWswioSsx/eBlspihQ66ztP8BsXgFBiR+T77GA2JwCThLT+lsYQVqZ BfQk7l/UgtgkL7F5zVvmCYyCs5B0zEKomoWkagEj8ypG0dTS5ILipPRcI73ixNzi0rx0veT8 3E2MkFD+uoNx6TGrQ4wCHIxKPLwRuyLDhVgTy4orcw8xSnAwK4nwah+KChfiTUmsrEotyo8v Ks1JLT7EKM3BoiTOO3PX+xAhgfTEktTs1NSC1CKYLBMHp1QDY8Km5sCSPia9Q485Td+tXbLu 0uV7z7faWK2ZsjeDYVrPgypPxRyHlrzX1qxhMSH1ji92TKvdV/9+sj5bfJbZjIjVnwxOJM5/ mRF5MnzVBsPcpevUFbMEFE+s2NErt+aOr/fRiWZ7FcL+XE1gYpATeXrLbsn8Yr/Ww5MUtYO3 CuxZ/smv5dBWTyWW4oxEQy3mouJEAN5Cyz9hAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/2016 02:32 PM, Chris Lapa wrote: > From: Chris Lapa > > Signed-off-by: Chris Lapa > --- > .../devicetree/bindings/power/max8903-charger.txt | 30 ++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/max8903-charger.txt You again skipped all of the maintainers. Your patch won't be applied. You need to send the patch to the appropriate person so he/she could apply it. >>From this patch: Rob Herring (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,commit_signer:9/19=47%) Mark Rutland (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) >>From power suppyy tree: Sebastian Reichel (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) Dmitry Eremin-Solenikov (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) David Woodhouse (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS) > diff --git a/Documentation/devicetree/bindings/power/max8903-charger.txt b/Documentation/devicetree/bindings/power/max8903-charger.txt > new file mode 100644 > index 0000000..e0b5366 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/max8903-charger.txt > @@ -0,0 +1,30 @@ > +Maxim Semiconductor MAX8903 Battery Charger bindings > + > +Required properties: > +- compatible: "maxim,max8903-charger" for MAX8903 Battery Charger > +- dc_valid: Specifies that the DC portion of the MAX8903 has been connected up > + and that dok-gpios should be specified You don't need the dc_valid nor the usb_valid. If the dok-gpios are present - use DC power. If the uok-gpios - USB power. If both or none: print error. BTW, It would be nice if send also the user of this bindings - DTS/DTSI. Best regards, Krzysztof > + - dok-gpios: Valid DC power has been detected > +- usb_valid: Specifies that the USB portion of the MAX8903 has been connected up > + and that uok-gpios should be specified > + - uok-gpios: Valid USB power has been detected > + > +Optional properties: > +- cen-gpios: Charge enable pin > +- chg-gpios: Charger status pin > +- flt-gpios: Fault pin > +- dcm-gpios: Current limit mode setting (DC or USB) > +- usus-gpios: USB suspend pin > + > + > +Example: > + > + max8903-charger { > + compatible = "maxim,max8903-charger"; > + dok-gpios = <&gpio2 3 GPIO_ACTIVE_LOW>; > + flt-gpios = <&gpio2 2 GPIO_ACTIVE_LOW>; > + chg-gpios = <&gpio3 15 GPIO_ACTIVE_LOW>; > + cen-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>; > + dc_valid; > + status = "okay"; > + }; >