From: John Johansen <john.johansen@canonical.com>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>
Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] apparmor: do not expose kernel stack
Date: Fri, 10 Jun 2016 15:13:44 -0700 [thread overview]
Message-ID: <575B3B98.5010606@canonical.com> (raw)
In-Reply-To: <1465594466-16581-1-git-send-email-xypron.glpk@gmx.de>
On 06/10/2016 02:34 PM, Heinrich Schuchardt wrote:
> Do not copy uninitalized fields th.td_hilen, th.td_data.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Acked-by: John Johansen <john.johansen@canonical.com>
I have a queue of patches I need to push this weekend so I
will suck this one in and send it up with the rest
> ---
> security/apparmor/match.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/security/apparmor/match.c b/security/apparmor/match.c
> index 727eb42..1d6dbd8 100644
> --- a/security/apparmor/match.c
> +++ b/security/apparmor/match.c
> @@ -61,7 +61,9 @@ static struct table_header *unpack_table(char *blob, size_t bsize)
>
> table = kvzalloc(tsize);
> if (table) {
> - *table = th;
> + table->td_id = th.td_id;
> + table->td_flags = th.td_flags;
> + table->td_lolen = th.td_lolen;
> if (th.td_flags == YYTD_DATA8)
> UNPACK_ARRAY(table->td_data, blob, th.td_lolen,
> u8, byte_to_byte);
>
prev parent reply other threads:[~2016-06-10 22:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 21:34 [PATCH 1/1] apparmor: do not expose kernel stack Heinrich Schuchardt
2016-06-10 22:13 ` John Johansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575B3B98.5010606@canonical.com \
--to=john.johansen@canonical.com \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox