From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753350AbcFKA7X (ORCPT <rfc822;w@1wt.eu>);
	Fri, 10 Jun 2016 20:59:23 -0400
Received: from mail-pf0-f171.google.com ([209.85.192.171]:33481 "EHLO
	mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751967AbcFKA7U (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Jun 2016 20:59:20 -0400
Subject: Re: [PATCH v8 2/5] perf config: Bring declarations about config from
 util/cache.h to util/config.h
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
References: <1465389413-8936-1-git-send-email-treeze.taeung@gmail.com>
 <1465389413-8936-3-git-send-email-treeze.taeung@gmail.com>
 <20160609132957.GI11589@kernel.org> <575A5C3B.2010804@gmail.com>
 <20160610190652.GD3826@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Masami Hiramatsu <mhiramat@kernel.org>, Wang Nan <wangnan0@huawei.com>,
        Jiri Olsa <jolsa@redhat.com>
From: Taeung Song <treeze.taeung@gmail.com>
Message-ID: <575B6262.6030607@gmail.com>
Date: Sat, 11 Jun 2016 09:59:14 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <20160610190652.GD3826@kernel.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Good evening :)

On 06/11/2016 04:06 AM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jun 10, 2016 at 03:20:43PM +0900, Taeung Song escreveu:
>> On 06/09/2016 10:29 PM, Arnaldo Carvalho de Melo wrote:
>>>> +++ b/tools/perf/util/cache.h
>>>> @@ -7,6 +7,7 @@
>>>>    #include <subcmd/pager.h>
>>>> +#include "config.h"
>
>>> Why have you added that? Are those config functions used in cache.h?
>
>> Yes, it does. Many source files include cache.h
>> e.g. builtin-annoate.c, util/color.c, builtin-report.c and etc.
>> And They can use perf_config() function including this header file.
>
>> So, If I totally eliminate not only declarations about config
>> but also #include "util/config.h" at util/cache.h,
>> we should add '#include "util/config.h"' to each source file that
>> need perf_config() overall.
>
> Sure, that is how we should do it. We should not include cache.h just to
> get what is in config.h, we should instead include config.h.
>
> This way when we do a change to cache.h we will not be rebuilding all
> those files that depend on it just to get config.h.
>
> What you're doing, removing from cache.h things that shouldn't be there
> in the first place is good, among other things, because of that.
>

Granted!
I've also experienced the situation all those files which include cache.h
are rebuilt after I changed cache.h.
It also seems a problem as you mention.

So, I'll send this patch that reflect what you said with v9.

Have a nice weekend :-D

Thanks,
Taeung