From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932199AbcFLCEE (ORCPT ); Sat, 11 Jun 2016 22:04:04 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:61658 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111AbcFLCEA (ORCPT ); Sat, 11 Jun 2016 22:04:00 -0400 Subject: Re: [PATCH] bcache: Remove deprecated create_workqueue To: Tejun Heo , Bhaktipriya Shridhar References: <20160607202719.GA16208@Karyakshetra> <20160611225202.GD31708@htj.duckdns.org> CC: Kent Overstreet , Shaohua Li , Eric Wheeler , Zheng Liu , Hannes Reinecke , Jeff Moyer , Pekka Enberg , Al Viro , , , From: Jens Axboe Message-ID: <575CC2F5.2030407@fb.com> Date: Sat, 11 Jun 2016 20:03:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160611225202.GD31708@htj.duckdns.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: DM3PR10CA0005.namprd10.prod.outlook.com (10.164.12.15) To BY2PR15MB0454.namprd15.prod.outlook.com (10.163.110.140) X-MS-Office365-Filtering-Correlation-Id: 362f552f-9fcc-44ff-fcfb-08d39265c895 X-Microsoft-Exchange-Diagnostics: 1;BY2PR15MB0454;2:zTUq2FIWDbl9vJhzrm0Ez9LasTOnyDLHI3YlRare1ojCmAJ0LG8geKHZGc5By65YKQ8sbSvsiCodLYUyRf/xcto/u3tZXeRBGtxfbmuMR5x25N7YcO86zIVUv3wSCIk566inxIg5bvbzYXt81EFechhOrmjqcWYDBp2Kulmw8RuEkXXfrknRavLl/UPsrG8S;3:1fhfwZ5T0tT7YljBQKNXfeJ6EtLXn9M9SvPUljdomTlglijF3X6ogHl8m2UsVAKjV1TQYvjUTxPOAXgvnoPgTecf7+sboJal4KR1tu1oxveeBNBBKLyoLjrJuhuazOn9 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR15MB0454; X-Microsoft-Exchange-Diagnostics: 1;BY2PR15MB0454;25:zl2PF9/sN1eq6P9D6yI1ykrr+pZi1ZjdnrKeHDc6CVu4aKm5lz/wIS2rZNKu5EwGbXkX13JPOtS/vUM+DaJOZbJn8zNUkjltbBmVuN9zEK3RM0jwCVJaXMCNk6mmZgsFeLW6mZSuF8g+hiyyx75wvCA2VxOcYpeaOJcKnvKcMLcH77TVMNYQr22cVRJzBSt5i+bxRBgZiWo4n1n+tcVxkAApCo3aXyZuTVAnLOqsvLiFqyIK0zqqDsFKjI753bN6QUbcQqdxoJv4rSQCygHQv55hR3JILr0HPU4eT1bx50DhXhVRArV3EcTc5qIpzT8bX9XBYx2J7bjys9tEMPVB501jSLZ87OjptyP+NfksgrJal09eqd6AN4oEVRBNIl3VrV4K5B1JAjutEWA0EpDpUeK6A9wqZHRDt8vefh5OWfY904+xVyp3GjC7aabtCIJ92uNOhJCMg6B10c5NJStAGrzzbAsZSTHU7LSWxjikbcgzHakKWgCqzXqWiKmMOLtDsyn3hCkFxt7XIIKxRMkAY1gLTBUPX0R+1qLDc56kpxoQWFlztNRNeAl+jjBOCV0EVbdUG0BCdNZGCUtDwd0VQ/g+01MbNApuRQe4atUP0SlamMojrZ7HYhv7+UPFC3V/eN4aw13jIh3rE/UagQ1NyDJ8z83HA+4rdku6qGRE2/YJTeaiHvtDG4/zdHXYpp7Ulapspt2z6wRwtcsn8HaTFA==;20:QJsIZl4aipTQm0G7Eyr+VUAHSHZuFQiXTFB54izNqFQsYAIeLDpmly1OQnqrhpw9ZenJRTsvE/xrUUwAGfFg/gy58ZmPhCEmy0d7mTcYWB9b7Aa6hHthCqG7Ngy7uvZwqYz1AgEmg+maMOMjNKBvSoRC53X1yLJ6NLdQiNNdFYA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:BY2PR15MB0454;BCL:0;PCL:0;RULEID:;SRVR:BY2PR15MB0454; X-Microsoft-Exchange-Diagnostics: 1;BY2PR15MB0454;4:MW+BtKiAjVE+YL4z8mj80Y1+aJ9kVGEME6XsByiUqk+jECFdFLLaj9oK0329V4XkziFg/uHT/jzGJ8Nc78Bn5WFB7q74/6KPfB8LMtENDBuPxnHRZZhkuQGHyjIpoiJmll85hyJu07Y9hiNLjh6iXxOxeU77SyyOAzKYOA40D3sRFXwcEhhiJcT6PRY5tyUIda1jfaI9v1Kg6Nl5LhqG3vir1E6RUpnLGTcqv7q7XZ2sUsu0i3jj+fwTM7s1ghxdJJzLVNEVxfJ3eyaZGzXRaU6pY1amysWEfMKfbVNY0Sjr4CSPUNOc+gVcSzGXnLHbStDSX0jXuXYW3mSybA1fQ9rzL6U/640A0hQUqPtXXSJpo8DuH/IP1nR8R3aXBynf X-Forefront-PRVS: 0971922F40 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(199003)(189002)(377454003)(24454002)(76176999)(50986999)(54356999)(87266999)(81166006)(81156014)(23746002)(4001350100001)(5001770100001)(97736004)(8676002)(189998001)(5004730100002)(65816999)(5008740100001)(6116002)(80316001)(19580405001)(19580395003)(3846002)(64126003)(586003)(92566002)(42186005)(230700001)(86362001)(83506001)(65806001)(65956001)(66066001)(36756003)(101416001)(4326007)(47776003)(50466002)(77096005)(2906002)(33656002)(2950100001)(59896002)(105586002)(106356001)(117156001)(68736007);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR15MB0454;H:[192.168.1.30];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2PR15MB0454;23:dTZgzLMJxZw5UPo7Fn6BE7owVRY5OB7v8Rb6l?= =?Windows-1252?Q?agMtY+ElMPi8oJPToQTB6T9mUInzR7zRhX7+MKL/rWpLfymu9PmnD9nm?= =?Windows-1252?Q?kVrpI+d2TJhYkZKl4ZltBtETKTsqLastURVA4HZiMGODudFrAhjgLPTA?= =?Windows-1252?Q?rE+p1nXPZoI/vtzjaHvb/sOngyHiT/iXYLmdge1dh7d7mvcXGSfc59ye?= =?Windows-1252?Q?fHoL5NJslYAp0s1HWTnnSQHIaqcwRTEjv1cTE6tM9xWksDa6BctqXQAH?= =?Windows-1252?Q?opk4qUXqI/ugDr/nNDlW+6DsKFCJSS4iAkgHBrehP5VnYxFFwxXNoAUS?= =?Windows-1252?Q?EmLNMoGxxoRjvQ/K0ARuLj5+fYkbk90U33p9np1t78Rl5+cuj33M0iX7?= =?Windows-1252?Q?XA4JDhC6S6HVDa02EOYZJU/ZnCP+0x+5pO/WuF0nVlTilt1CagcsL/b8?= =?Windows-1252?Q?IlbkAnPvxsu/GlvF7rNC/PbO/2fKItsNNwZzxezBUF1xaINtJfEcyQnw?= =?Windows-1252?Q?Zmv5sa3JQxG7jhzaYipCdxhSjgwjGYzNJae8ZGt7Pr2kImJDIAvGvN/A?= =?Windows-1252?Q?i/WBaJ9h9IHxV9QISUJKSQTDJ0reymilckMC5u3k+Llqs50+ikOtIpxE?= =?Windows-1252?Q?QZ/MuuJ4f+yAZ/dFsl+x/bu2aTMlb/wBTvVIXuQHlAT1SU+eqgJs3Qsd?= =?Windows-1252?Q?b5982V+GwDHvlqL4ks23Kntu6Qzn+SywcGwG0E7w9kxOnd68DzxM5Jmn?= =?Windows-1252?Q?6S5uasV8N5Wq0IPgIQRhmI7ERFtE78b9eEysMeXeMD0Mt8Bh8cwFhoau?= =?Windows-1252?Q?GenabaAD03nOLNoZsocHxe0ImoqRBzAYBiCyJH4tfZl8KY8oJ/rt/xLb?= =?Windows-1252?Q?379H8QAW9qnd0La61eVRTjydwoReRlP/W/eEFS3i3HsowNKxT6CI+zYo?= =?Windows-1252?Q?i6QpUmxxQab0V4j0yBbEov0lB9TLOLnc8SqGbXs8KBHxCelYgzOa7wXc?= =?Windows-1252?Q?sc3tO7ioUdPxQMoZ7UYz+/vCXq4eQpJjw0K6uV4Lly+W8CVdn/l4k6Oj?= =?Windows-1252?Q?go5cvM7HPkYwO6JjVVKyozOzLmJWbcH4KSMTrwtv9nDNGvjtVuivSCoV?= =?Windows-1252?Q?OXQl9tMNWcSuz24pWp6ZLa3ZEb1+Eiwf5bpi6vyOSGsPONgOJw0AxVKu?= =?Windows-1252?Q?/e6tQZsRfybYT3JusEJA3iMcw5iDsYZyJaeTwPfjGfzhzU4OFMnAQQZA?= =?Windows-1252?Q?CShXQ1JmL+yYe1TY/fftB4PGmTNdQK6RQQM9qCs7j1fdP8PAwSEEmOqc?= =?Windows-1252?Q?o5IQjwf+epKQTk4JycEX4xIHFie5Voh2P0yQmSSmgNxj3oxxtxt50V/S?= =?Windows-1252?Q?Ykwp9WJJ+6jIRvDTL2eNwPX+kWFghEEHoK9zK22Vi3UVQ1MQjrsAnk?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR15MB0454;5:GQBQeK/EBRdFKx3BiHFRkLOetGwj39eKsJpM18ZL2nsnvn7HLizAaSDlYTdxjfx5IsofufxF1M+gLBWwrKI/Ex3nmv26ZDskD4ZHAoimRQE6gmPGYaS8Lm4kgI/dGBk1hLFZC9Xb6hZVOJo85a8sQA==;24:fmCj5ary/CHvHH+YMjaTaCIsHnA4u82TZ9igcm9+YK8KfbQmARw3bWaVmzplLS9GykOM2bHculbpZI84GCmHs5c5Sw9Aqlttnw6vVEMCaFA=;7:m+Afkg9so99CQTOl7IK4Rqhl42bNz2BkBT6egSqBuZ9ThBzuVH0c6WdfEvK5Z+uTFN0mOvmBz/nTfq4HbPCFI1svTIPPCugTSKhMm3dATSFsFyEtl6aVdDotypMIzAlDO88osoicWbjEvZ9/Kr3IIODGh223mA7CY4/Fpq7BM3jwxx5P/Ks8An7j9CH7b2LnFLZbAsE3Fql/2aJ8GlRVPoCQIZujyQisat5Tf65DB6s=;20:BOfYutKW7MeP0f5NbKXhn6eshYrs/JOUO/7MwZ+93iGJNYqQXQni1/CK5qZ3tiCQCzR+yQFIqRoPJsr3eG8fLV1glYqWqQeHnk+YzAaX98iwIdn+vsLV38WHGmuTrBK+eKZMfQv7TKeuuRYBNrTmNUTdmv6S7ClFIp2AeqXJquc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2016 02:03:42.0558 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR15MB0454 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-11_18:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/2016 04:52 PM, Tejun Heo wrote: > On Wed, Jun 08, 2016 at 01:57:19AM +0530, Bhaktipriya Shridhar wrote: >> alloc_workqueue replaces deprecated create_workqueue(). >> >> Dedicated workqueues have been used since bcache_wq and moving_gc_wq >> are workqueues for writes and are being used on a memory reclaim path. >> WQ_MEM_RECLAIM has been set to ensure forward progress under memory >> pressure. >> Since there are only a fixed number of work items, explicit concurrency >> limit is unnecessary here. >> >> Signed-off-by: Bhaktipriya Shridhar > > Acked-by: Tejun Heo Added to 4.8, thanks. -- Jens Axboe