From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753179AbcFLCMc (ORCPT <rfc822;w@1wt.eu>);
	Sat, 11 Jun 2016 22:12:32 -0400
Received: from lucky1.263xmail.com ([211.157.147.132]:60671 "EHLO
	lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752172AbcFLCMb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 11 Jun 2016 22:12:31 -0400
X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S;
X-MAIL-GRAY: 1
X-MAIL-DELIVERY: 0
X-KSVirus-check: 0
X-ABS-CHECKED: 1
X-SKE-CHECKED: 1
X-ADDR-CHECKED: 0
X-RL-SENDER: ykk@rock-chips.com
X-FST-TO: linux-kernel@vger.kernel.org
X-SENDER-IP: 103.29.142.67
X-LOGIN-NAME: ykk@rock-chips.com
X-UNIQUE-TAG: <79223c0913c18dbbe62c0ca19c4fa93d>
X-ATTACHMENT-NUM: 0
X-DNS-TYPE: 0
Subject: Re: [PATCH v2 6/6] drm/panel: simple: Add support for Sharp
 LQ123P1JX31 2400x1600 panel
To: Doug Anderson <dianders@chromium.org>
References: <1465386727-27647-1-git-send-email-ykk@rock-chips.com>
 <1465386768-27947-1-git-send-email-ykk@rock-chips.com>
 <CAD=FV=V2RF+Wr_6PfoV1EVr1djauZASC=vEsYCaXvRtjd523KQ@mail.gmail.com>
 <CAD=FV=Vmh-weKJLdDY=zfLRL9bMzDGvSV5gN=jaRV3d-b+jxiw@mail.gmail.com>
Cc: David Airlie <airlied@linux.ie>, Thierry Reding <thierry.reding@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>, Kumar Gala <galak@codeaurora.org>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From: Yakir Yang <ykk@rock-chips.com>
Message-ID: <575CC504.9040301@rock-chips.com>
Date: Sun, 12 Jun 2016 10:12:20 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <CAD=FV=Vmh-weKJLdDY=zfLRL9bMzDGvSV5gN=jaRV3d-b+jxiw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Doug,

On 06/11/2016 12:11 AM, Doug Anderson wrote:
> Hi,
>
> On Wed, Jun 8, 2016 at 9:35 AM, Doug Anderson <dianders@chromium.org> wrote:
>> Yakir,
>>
>> On Wed, Jun 8, 2016 at 4:52 AM, Yakir Yang <ykk@rock-chips.com> wrote:
>>> The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected
>>> using eDP interfaces.
>>>
>>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>>> ---
>>> Changes in v2:
>>> - Add detail timing of Sharp LQ123P1JX31 panel in v2
>>>
>>>   drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
>>>   1 file changed, 26 insertions(+)
>> Looks good to me.  Values in the table match the EDID I see from this
>> panel and everything else looks to be in order.
>>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>> Tested-by: Doug Anderson <dianders@chromium.org>
> Sorry for not noticing.  :(  ...but as others have pointed out for
> your earlier patches, the size is incorrect.  I found the correct size
> and it should be:
>
>                 .width = 259,
>                 .height = 173,
>

Ah, thanks, would correct it now :-D

- Yakir

> -Doug
>
>
>