From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753308AbcFLCOa (ORCPT ); Sat, 11 Jun 2016 22:14:30 -0400 Received: from lucky1.263xmail.com ([211.157.147.130]:42122 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752602AbcFLCO3 (ORCPT ); Sat, 11 Jun 2016 22:14:29 -0400 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v2 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding To: Doug Anderson , Rob Herring References: <1465386727-27647-1-git-send-email-ykk@rock-chips.com> <1465386765-27867-1-git-send-email-ykk@rock-chips.com> <20160610134217.GA25881@rob-hp-laptop> Cc: David Airlie , Thierry Reding , Pawel Moll , Mark Rutland , Kumar Gala , Ian Campbell , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Yakir Yang Message-ID: <575CC57B.6050404@rock-chips.com> Date: Sun, 12 Jun 2016 10:14:19 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/2016 12:40 AM, Doug Anderson wrote: > Rob, > > On Fri, Jun 10, 2016 at 6:42 AM, Rob Herring wrote: >> On Wed, Jun 08, 2016 at 07:52:45PM +0800, Yakir Yang wrote: >>> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel >>> connected using eDP interfaces. >>> >>> Signed-off-by: Yakir Yang >>> --- >>> Changes in v2: >>> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2 >>> >>> .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >>> >>> diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >>> new file mode 100644 >>> index 0000000..81938c0 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt >>> @@ -0,0 +1,7 @@ >>> +Sharp 12.3" (2400x1600 pixels) TFT LCD panel >>> + >>> +Required properties: >>> +- compatible: should be "sharp,lq123p1jx31," >> ^ >> Need to drop the comma. > Thanks for catching! Done, > >> No regulators or resets or pwms? > Could be more explicit I guess, but Yakir does say: > >> This binding is compatible with the simple-panel binding, which is specified >> in simple-panel.txt in this directory. > In that document it shows: > > Required properties: > - power-supply: regulator to provide the supply voltage > > Optional properties: > - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing > - enable-gpios: GPIO pin to enable or disable the panel > - backlight: phandle of the backlight device attached to the panel > > > In general Yakir's bindings document match a huge chunk of the current > existing bindings. Do this: > cd Documentation/devicetree/bindings/display/panel > grep -C20 "This binding is compatible with the simple-panel" * > > You'll find a huge chunk of files which are rather formulaic. It > might make sense to just have one file and a list of panels which are > simple panels? > > > -Doug > > >