From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751548AbcFLKIx (ORCPT ); Sun, 12 Jun 2016 06:08:53 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:26512 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbcFLKIv (ORCPT ); Sun, 12 Jun 2016 06:08:51 -0400 Subject: Re: [PATCH 0/3] Fixes on remote unwind To: , , Peter Zijlstra , , , , , , , , , , , , , , References: <1465380938-64371-1-git-send-email-hekuang@huawei.com> CC: From: Hekuang Message-ID: <575D337E.8010809@huawei.com> Date: Sun, 12 Jun 2016 18:03:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1465380938-64371-1-git-send-email-hekuang@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.110.55.166] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.575D338A.005D,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 1365e1e8ba9ca29aabe409e0d965ab47 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016/6/8 18:15, He Kuang 写道: > The remote unwind can supported scenario where we collect on a x86_64 > machine and want to do analysis on a ARM64 or x86-32 machine. Though > this is not tested, after Arnaldo questioned the above issue, I tested > and found a bug. > > In util/unwind-libunwind-local.c, PERF_REG_SP/IP is used, but those > macros are assigned to the host platform, we should redefine them in > the wrapper file, for example in "util/libunwind/x86_32.c". > > After fixing this problem, i686 perf.data can be parsed on aarch64 > machine. > > To Arnaldo, I noticed that this patch > "perf tools: Find vdso supporting cross-platform analysis" > is not on "origin/perf/unwind" branch, this patch was applied, please > check if it was missed, the above test needs this patch. I also checked tip.git, this patch is not there either, is this patch missed? This is the previous git pull request mail: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1148601.html Thank you. > > Thank you. > > He Kuang (3): > perf unwind: Change macro names of perf register > perf unwind: Fix wrongly used regs for x86_32 unwind > perf unwind: Fix wrongly used regs for aarch64 unwind > > tools/perf/util/libunwind/arm64.c | 5 +++++ > tools/perf/util/libunwind/x86_32.c | 6 ++++++ > tools/perf/util/unwind-libunwind-local.c | 6 ++++-- > tools/perf/util/unwind.h | 9 +++++++++ > 4 files changed, 24 insertions(+), 2 deletions(-) >