From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933334AbcFMBiV (ORCPT ); Sun, 12 Jun 2016 21:38:21 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:55640 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933059AbcFMBiU (ORCPT ); Sun, 12 Jun 2016 21:38:20 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee690-f79056d000001327-13-575e0e89caca Content-transfer-encoding: 8BIT Message-id: <575E0E89.40400@samsung.com> Date: Mon, 13 Jun 2016 10:38:17 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Javier Martinez Canillas Cc: Javier Martinez Canillas , Linux Kernel , Marc Zyngier , Kukjin Kim , Seung-Woo Kim , "dri-devel@lists.freedesktop.org" , "linux-samsung-soc@vger.kernel.org" , Kyungmin Park , Krzysztof Kozlowski , David Airlie , Joonyoung Shim , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] drm/exynos: don't use HW trigger for Exynos5420/5422/5800 References: <1464877210-27207-1-git-send-email-javier@osg.samsung.com> <5758A58D.7050106@samsung.com> <6e24059d-16f3-210a-8dd2-f8dcb89213a1@osg.samsung.com> <5759EF32.5040302@samsung.com> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLIsWRmVeSWpSXmKPExsWyRsSkQLeTLy7cYPs7M4vecyeZLK58fc9m ce33DDaLN2/XMFm8uHeRxeL1C0OL/sevmS3ONr1ht9j0+BqrxeVdc9gsZpzfx2Tx984/IGvy SzYHXo8189Ywevyd3crssWlVJ5vH9m8PWD3udx9n8ti8pN5jS/9ddo++LasYPT5vkgvgjOKy SUnNySxLLdK3S+DKePnXoWAWT8W2fRNYGhiPc3YxcnJICJhI3G2eyw5hi0lcuLeerYuRi0NI YAWjxJVPN5hhiuZ+Pg6VmMUosWrxTrAEr4CgxI/J91i6GDk4mAXkJY5cyoYw1SWmTMmFKH/A KHH2wTY2kDivgIbE8iUWICaLgKrEzxNeIEPYgMyJK+6DVYgKREh0n6gECYsIGEl07rrKAjKF WeARi8SRix9YQRLCAn4SN08fZIEYf49JYs2m9WDNnALBEjcf64LEJQSmcki0/v4J9heLgIDE t8mHwK6UEJCV2HQA6itJiYMrbrBMYBSbheSXWQi/zEL4ZQEj8ypG0dSC5ILipPQiE73ixNzi 0rx0veT83E2MwFg+/e/ZhB2M9w5YH2IU4GBU4uHVWBUbLsSaWFZcmXuI0RTohonMUqLJ+cCE kVcSb2hsZmRhamJqbGRuaaYkzvta6mewkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6pBsYJbO4b I7zOqf3WDN/3MDj1jl9ClcnrwnNPEv1Urt/sOGqwPGJjk8OE5xY8kkl5bBGr5SLdj2ev4lhv uKeq86rkfNva331r0w45nP4acmfh4+87Qiaz8NzKnm2WZut7X/64yAWGbwWu0yvYiy/VmitN uxFzed2HwCPsPIV6NqXGlrVez+yublBiKc5INNRiLipOBACE5RSQ4AIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsVy+t9jQd1Ovrhwg5M9Bha9504yWVz5+p7N 4trvGWwWb96uYbJ4ce8ii8XrF4YW/Y9fM1ucbXrDbrHp8TVWi8u75rBZzDi/j8ni751/QNbk l2wOvB5r5q1h9Pg7u5XZY9OqTjaP7d8esHrc7z7O5LF5Sb3Hlv677B59W1YxenzeJBfAGdXA aJORmpiSWqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDdLeSQlli TilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCGMePlX4eCWTwV2/ZNYGlgPM7ZxcjJ ISFgIjH383E2CFtM4sK99UA2F4eQwCxGiVWLdzKDJHgFBCV+TL7H0sXIwcEsIC9x5FI2hKku MWVKLkT5A0aJsw+2sYHEeQU0JJYvsQAxWQRUJX6e8AIZwgZkTlxxH6xCVCBCovtEJUhYRMBI onPXVRaQKcwCj1gkjlz8wAqSEBbwk7h5+iALxPh7TBJrNq0Ha+YUCJa4+Vh3AiPQiQi3zUK4 bRbCbQsYmVcxSqQWJBcUJ6XnGuWllusVJ+YWl+al6yXn525iBKeLZ9I7GA/vcj/EKMDBqMTD q7EqNlyINbGsuDL3EKMEB7OSCG8We1y4EG9KYmVValF+fFFpTmrxIUZToO8mMkuJJucDU1le SbyhsYmZkaWRuaGFkbG5kjjv4//rwoQE0hNLUrNTUwtSi2D6mDg4pRoYhYoUZ5dkbJ5jscj+ 9PMZW28bLbht/XvPN6nMiANv51cxB4e/WsOw/xUrf/5mQ4myn0Z7eVzeR/AtubD1oWTG13tl 4ntbrrHeWcW93vocy2+XDcsTA1KmeTJUPrnE+Px2tp6ggO7n+PIEDxmN3wIifbae0x701apn n2TvfSpbm2BW1vEzh1FSiaU4I9FQi7moOBEAGE79Yy0DAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016년 06월 10일 09:24에 Javier Martinez Canillas 이(가) 쓴 글: > Hello Inki, > > On Thu, Jun 9, 2016 at 6:35 PM, Inki Dae wrote: > > [snip] > >>> I know that removing .trg_type is enough but I also removed those lines >>> because the fields are not used if .trg_type != I80_HW_TRG. So there is >>> no point to leave a set for unused fields. >>> >>> We can latter add those one HW trigger support is fixed for Exynos5420. >>> >> >> As of now, I can merge it but I think it would be not reasonable solution because potential problem still exists even we use SW trigger mode in default - ie., in case of using HW trigger mode at bootloader, same problem would happen as long as we don't support PSR mode support. >> > > Yes, I understand that the problem will show again if the bootloader > uses HW trigger mode and that we need proper Panel Self Refresh > support but I think that's a separate issue. That's why I said that > those can be addressed for v4.8 but revert to SW trigger for v4.7 as a > short term fix for the regression. > > In other words, enabling HW trigger mode breaks the display for the > Exynos5420 and Exynos5800 Peach Pi Chromebooks with the shipped > bootloaders (which are probably the most popular Exynos5 devices with > display and mainline support so is likely to affect users). I thought to add PSR support somehow but put me other things to trouble. Anyway, we could support it later so picked it up. Thanks, Inki Dae > > Best regards, > Javier > > >