From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753565AbcFMGSx (ORCPT ); Mon, 13 Jun 2016 02:18:53 -0400 Received: from thoth.sbs.de ([192.35.17.2]:50724 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbcFMGSw (ORCPT ); Mon, 13 Jun 2016 02:18:52 -0400 Subject: Re: [PATCH] scripts/gdb: Perform path expansion to lx-symbol's arguments To: Nikolay Borisov , Kieran Bingham References: <5757F1BE.703@siemens.com> <1465403312-18254-1-git-send-email-n.borisov.lkml@gmail.com> Cc: linux-kernel@vger.kernel.org From: Jan Kiszka Message-ID: <575E5048.6040204@siemens.com> Date: Mon, 13 Jun 2016 08:18:48 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <1465403312-18254-1-git-send-email-n.borisov.lkml@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-06-08 18:28, Nikolay Borisov wrote: > Python doesn't do automatic expansion of paths. In case one passes > path of the from ~/foo/bar the gdb scripts won't automatically expand > that and as a result the symbols files won't be loaded. Fix this > by explicitly expanding all paths which begin with "~" > > Signed-off-by: Nikolay Borisov > --- > scripts/gdb/linux/symbols.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py > index 9a0f8923f67c..004b0ac7fa72 100644 > --- a/scripts/gdb/linux/symbols.py > +++ b/scripts/gdb/linux/symbols.py > @@ -153,7 +153,7 @@ lx-symbols command.""" > saved_state['breakpoint'].enabled = saved_state['enabled'] > > def invoke(self, arg, from_tty): > - self.module_paths = arg.split() > + self.module_paths = [os.path.expanduser(p) for p in arg.split()] > self.module_paths.append(os.getcwd()) > > # enforce update > Reviewed-by: Jan Kiszka Kieran, will you take this, as you are already preparing other patches? Thanks, Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux