From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965141AbcFMH6B (ORCPT ); Mon, 13 Jun 2016 03:58:01 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:37208 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964793AbcFMH56 (ORCPT ); Mon, 13 Jun 2016 03:57:58 -0400 X-AuditID: cbfec7f4-f796c6d000001486-e6-575e67837c50 Message-id: <575E6781.7090503@samsung.com> Date: Mon, 13 Jun 2016 09:57:53 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Stephan Linz Cc: linux-leds@vger.kernel.org, linux-ide@vger.kernel.org, Guan Xuetao , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 7/7] unicore32: use the new LED disk activity trigger References: <20160610060021.12382-1-linz@li-pro.net> <20160610060021.12382-7-linz@li-pro.net> In-reply-to: <20160610060021.12382-7-linz@li-pro.net> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCLMWRmVeSWpSXmKPExsVy+t/xq7rN6XHhBstuM1kcvPGN3eLYjkdM Fpd3zWGz2PpmHaPF1deLWBxYPXa/TfV4vNfS4/MmuQDmKC6blNSczLLUIn27BK6MbXfOsBZ0 8VasOX+btYHxIVcXIweHhICJxJWnrF2MnECmmMSFe+vZuhi5OIQEljJKbJn7jR3CecYo8XLz LHaQKl4BLYkvmw+xgdgsAqoSx078YAGx2QQMJX6+eM0EYosKREj8Ob2PFaJeUOLH5HtgNSIC ShKTnrSygyxmFqiReHU+DCQsLOAjsbT5NCOILSQQL3F6/zxmEJtTwFRiyv+fYKuYBawlVk7a xghhy0tsXvOWeQKjwCwkG2YhKZuFpGwBI/MqRtHU0uSC4qT0XEO94sTc4tK8dL3k/NxNjJCw /bKDcfExq0OMAhyMSjy8hn9iw4VYE8uKK3MPMUpwMCuJ8EalxoUL8aYkVlalFuXHF5XmpBYf YpTmYFES5527632IkEB6YklqdmpqQWoRTJaJg1OqgdF1IpvWxDM3lfplDy8/KindrHKkd+vH PPsypwdShbEXVv95m7v5xkq9ptVZi17uUgj5aZX3b70d1912veeSy7/vOhK/ePGcy9/bNk6M YLQ7L/0pi63fPiu55sJJsUdZL0wyPi0TTv94vsf0wCY1gePPC4J+sG0NY9GxuF1uoN80585x /juaZp5KLMUZiYZazEXFiQAEKN0tVwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guan, For consistency reasons this patch should be merged through LED tree, but I need an ack for this. Thanks, Jacek Anaszewski On 06/10/2016 08:00 AM, Stephan Linz wrote: > - platform: rename 'ide-disk' to 'disk-activity' > - defconfig: rename 'LEDS_TRIGGER_IDE_DISK' to 'LEDS_TRIGGER_DISK' > > Signed-off-by: Stephan Linz > --- > arch/unicore32/configs/unicore32_defconfig | 2 +- > arch/unicore32/kernel/gpio.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/unicore32/configs/unicore32_defconfig b/arch/unicore32/configs/unicore32_defconfig > index 45f47f8..aebd01f 100644 > --- a/arch/unicore32/configs/unicore32_defconfig > +++ b/arch/unicore32/configs/unicore32_defconfig > @@ -161,7 +161,7 @@ CONFIG_LEDS_GPIO=y > # LED Triggers > CONFIG_LEDS_TRIGGERS=y > CONFIG_LEDS_TRIGGER_TIMER=y > -CONFIG_LEDS_TRIGGER_IDE_DISK=y > +CONFIG_LEDS_TRIGGER_DISK=y > CONFIG_LEDS_TRIGGER_HEARTBEAT=y > > # Real Time Clock > diff --git a/arch/unicore32/kernel/gpio.c b/arch/unicore32/kernel/gpio.c > index 49347a0..bf164bb 100644 > --- a/arch/unicore32/kernel/gpio.c > +++ b/arch/unicore32/kernel/gpio.c > @@ -27,7 +27,7 @@ static const struct gpio_led puv3_gpio_leds[] = { > { .name = "cpuhealth", .gpio = GPO_CPU_HEALTH, .active_low = 0, > .default_trigger = "heartbeat", }, > { .name = "hdd_led", .gpio = GPO_HDD_LED, .active_low = 1, > - .default_trigger = "ide-disk", }, > + .default_trigger = "disk-activity", }, > }; > > static const struct gpio_led_platform_data puv3_gpio_led_data = { > -- Best regards, Jacek Anaszewski