From: Jon Hunter <jonathanh@nvidia.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Kevin Hilman <khilman@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Lars-Peter Clausen <lars@metafoo.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
<linux-tegra@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V6 9/9] irqchip/gic: Add platform driver for non-root GICs that require RPM
Date: Mon, 13 Jun 2016 11:27:38 +0100 [thread overview]
Message-ID: <575E8A9A.1040907@nvidia.com> (raw)
In-Reply-To: <575E8741.8060902@arm.com>
On 13/06/16 11:13, Marc Zyngier wrote:
...
> OK, that's because ARM_GIC_PM is never selected (and there is no way I
> can actually select). Do you have some additional patches that selects
> it for Tegra?
Yes locally, I have the following for testing ...
diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
index 03089ad2fc65..ffd02a3c093a 100644
--- a/drivers/soc/tegra/Kconfig
+++ b/drivers/soc/tegra/Kconfig
@@ -63,6 +63,7 @@ config ARCH_TEGRA_132_SOC
config ARCH_TEGRA_210_SOC
bool "NVIDIA Tegra210 SoC"
+ select ARM_GIC_PM
select PINCTRL_TEGRA210
>> The correct fix is ...
>>
>> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
>> index 57423f3b218b..1de07eb5839c 100644
>> --- a/drivers/irqchip/irq-gic.c
>> +++ b/drivers/irqchip/irq-gic.c
>> @@ -1272,7 +1272,7 @@ static bool gic_check_eoimode(struct device_node *node, void __iomem **base)
>> return true;
>> }
>>
>> -static int __init gic_of_setup(struct gic_chip_data *gic, struct device_node *node)
>> +static int gic_of_setup(struct gic_chip_data *gic, struct device_node *node)
>> {
>> if (!gic || !node)
>> return -EINVAL;
>
> OK, I've applied this locally (no need to resend).
Great. Thanks. Sorry about this.
Jon
--
nvpublic
prev parent reply other threads:[~2016-06-13 10:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 15:12 [PATCH V6 0/9] Add support for Tegra210 AGIC Jon Hunter
2016-06-07 15:12 ` [PATCH V6 1/9] irqdomain: Fix handling of type settings for existing mappings Jon Hunter
2016-06-07 15:12 ` [PATCH V6 2/9] genirq: Look-up trigger type if not specified by caller Jon Hunter
2016-06-13 10:42 ` Marc Zyngier
2016-06-13 11:09 ` Jon Hunter
2016-06-13 11:59 ` Marc Zyngier
2016-06-13 12:24 ` Jon Hunter
2016-06-13 12:33 ` Marc Zyngier
2016-06-07 15:12 ` [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ Jon Hunter
2016-07-29 3:53 ` Masahiro Yamada
2016-07-29 8:10 ` Marc Zyngier
2016-08-01 1:28 ` Masahiro Yamada
2016-08-01 7:46 ` Marc Zyngier
2016-08-01 8:30 ` Masahiro Yamada
2016-07-29 8:31 ` Jon Hunter
2016-08-01 3:09 ` Masahiro Yamada
2017-08-17 12:46 ` [V6,3/9] " jeffy
2017-08-17 13:34 ` Marc Zyngier
2017-08-17 14:42 ` jeffy
2016-06-07 15:12 ` [PATCH V6 4/9] genirq: Add runtime power management support for IRQ chips Jon Hunter
2016-06-10 22:08 ` Kevin Hilman
2016-06-07 15:12 ` [PATCH V6 5/9] irqchip/gic: Isolate early GIC initialisation code Jon Hunter
2016-06-07 15:12 ` [PATCH V6 6/9] irqchip/gic: Add helper function for chip initialisation Jon Hunter
2016-06-07 15:12 ` [PATCH V6 7/9] irqchip/gic: Prepare for adding platform driver Jon Hunter
2016-06-07 15:12 ` [PATCH V6 8/9] dt-bindings: arm-gic: Add documentation for Tegra210 AGIC Jon Hunter
2016-06-07 15:12 ` [PATCH V6 9/9] irqchip/gic: Add platform driver for non-root GICs that require RPM Jon Hunter
2016-06-13 9:10 ` Marc Zyngier
2016-06-13 9:58 ` Jon Hunter
2016-06-13 10:13 ` Marc Zyngier
2016-06-13 10:27 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575E8A9A.1040907@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=geert@linux-m68k.org \
--cc=grygorii.strashko@ti.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=khilman@kernel.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox