From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751365AbcFNGM0 (ORCPT ); Tue, 14 Jun 2016 02:12:26 -0400 Received: from mail-cys01nam02on0043.outbound.protection.outlook.com ([104.47.37.43]:65090 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751153AbcFNGMZ (ORCPT ); Tue, 14 Jun 2016 02:12:25 -0400 X-Greylist: delayed 902 seconds by postgrey-1.27 at vger.kernel.org; Tue, 14 Jun 2016 02:12:24 EDT Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; windriver.com; dkim=none (message not signed) header.d=none;windriver.com; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH 4/5] reset: zynq: make it explicitly non-modular To: Paul Gortmaker , References: <20160613180338.29199-1-paul.gortmaker@windriver.com> <20160613180338.29199-5-paul.gortmaker@windriver.com> CC: Philipp Zabel , Michal Simek , =?UTF-8?Q?S=c3=b6ren_Brinkmann?= , Moritz Fischer From: Michal Simek Message-ID: <575F9CB1.5080709@xilinx.com> Date: Tue, 14 Jun 2016 07:57:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160613180338.29199-5-paul.gortmaker@windriver.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22388.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.100;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(189002)(199003)(24454002)(87936001)(5001770100001)(36386004)(9786002)(4001350100001)(356003)(63266004)(23676002)(189998001)(2870700001)(81156014)(81166006)(83506001)(586003)(8676002)(2950100001)(8936002)(4326007)(80316001)(19580405001)(77096005)(19580395003)(5008740100001)(2906002)(6806005)(33656002)(36756003)(11100500001)(50466002)(64126003)(106466001)(87266999)(54356999)(76176999)(50986999)(65816999)(47776003)(65806001)(92566002)(65956001)(59896002)(86362001)(107986001)(2004002)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1NAM02HT012;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;MX:1;A:1;CAT:NONE;LANG:en;CAT:NONE; X-MS-Office365-Filtering-Correlation-Id: d86dfb85-9c9b-460c-6687-08d39418b99d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:CY1NAM02HT012; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13023025)(13024025)(13017025)(13018025)(13015025)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:CY1NAM02HT012;BCL:0;PCL:0;RULEID:;SRVR:CY1NAM02HT012; X-Forefront-PRVS: 09730BD177 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2016 05:57:10.0628 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1NAM02HT012 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13.6.2016 20:03, Paul Gortmaker wrote: > The Makefile/Kconfig currently controlling compilation of this code is: > > drivers/reset/Makefile:obj-$(CONFIG_ARCH_ZYNQ) += reset-zynq.o > arch/arm/mach:zynq/Kconfig:config ARCH_ZYNQ > arch/arm/mach:zynq/Kconfig: bool "Xilinx Zynq ARM Cortex A9 Platform" if ARCH_MULTI_V7 > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the few remaining traces of modular macro usage, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Philipp Zabel > Cc: Michal Simek > Cc: "Sören Brinkmann" > Cc: Moritz Fischer > Signed-off-by: Paul Gortmaker > --- > drivers/reset/reset-zynq.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/reset/reset-zynq.c b/drivers/reset/reset-zynq.c > index 138f2f205662..87a4e355578f 100644 > --- a/drivers/reset/reset-zynq.c > +++ b/drivers/reset/reset-zynq.c > @@ -3,6 +3,8 @@ > * > * Xilinx Zynq Reset controller driver > * > + * Author: Moritz Fischer > + * > * This program is free software; you can redistribute it and/or modify > * it under the terms of the GNU General Public License as published by > * the Free Software Foundation; version 2 of the License. > @@ -15,7 +17,7 @@ > > #include > #include > -#include > +#include > #include > #include > #include > @@ -137,8 +139,4 @@ static struct platform_driver zynq_reset_driver = { > .of_match_table = zynq_reset_dt_ids, > }, > }; > -module_platform_driver(zynq_reset_driver); > - > -MODULE_LICENSE("GPL v2"); > -MODULE_AUTHOR("Moritz Fischer "); > -MODULE_DESCRIPTION("Zynq Reset Controller Driver"); > +builtin_platform_driver(zynq_reset_driver); > Acked-by: Michal Simek Thanks, Michal