From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751291AbcFNKkU (ORCPT ); Tue, 14 Jun 2016 06:40:20 -0400 Received: from mga02.intel.com ([134.134.136.20]:52247 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750818AbcFNKkS (ORCPT ); Tue, 14 Jun 2016 06:40:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,470,1459839600"; d="scan'208";a="987094803" Subject: Re: [PATCH] mmc: Change the enhanced area related sysfs output format To: Wolfram Sang , Beata Baranowska References: <1465893186-6399-1-git-send-email-beatax.baranowska@intel.com> <20160614101242.GA1603@katana> Cc: ulf.hansson@linaro.org, aisheng.dong@nxp.com, wsa+renesas@sang-engineering.com, gwendal@chromium.org, chaotian.jing@mediatek.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, sebastianx.jarosz@intel.com, Chuanxiao Dong From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <575FDE1B.2090206@intel.com> Date: Tue, 14 Jun 2016 13:36:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160614101242.GA1603@katana> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/06/16 13:12, Wolfram Sang wrote: > On Tue, Jun 14, 2016 at 10:33:06AM +0200, Beata Baranowska wrote: >> From: Chuanxiao Dong >> >> When the enhanced area feature was not enabled, the related sysfs will >> have -EINVAL(-22) value, so change the sysfs output format to display >> the correct value. >> >> Signed-off-by: Chuanxiao Dong > > What about introducing attribute_group an use the is_visible callback > there, so they won't get displayed at all? > Except that it is an ABI: Documentation/ABI/testing/sysfs-devices-mmc