From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752611AbcFNPs2 (ORCPT ); Tue, 14 Jun 2016 11:48:28 -0400 Received: from ale.deltatee.com ([207.54.116.67]:38467 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752464AbcFNPs0 (ORCPT ); Tue, 14 Jun 2016 11:48:26 -0400 To: Allen Hubbe , "'Allen Hubbe'" References: <575C2E28.9020604@deltatee.com> <000101d1c653$bc673280$35359780$@emc.com> Cc: "'Jon Mason'" , "'Dave Jiang'" , "'Shuah Khan'" , "'Sudip Mukherjee'" , "'Arnd Bergmann'" , linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com, linux-kselftest@vger.kernel.org From: Logan Gunthorpe Message-ID: <57602736.7090709@deltatee.com> Date: Tue, 14 Jun 2016 09:48:06 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.8.0 MIME-Version: 1.0 In-Reply-To: <000101d1c653$bc673280$35359780$@emc.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.111 X-SA-Exim-Rcpt-To: linux-kselftest@vger.kernel.org, linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org, arnd@arndb.de, sudipm.mukherjee@gmail.com, shuahkh@osg.samsung.com, dave.jiang@intel.com, jdmason@kudzu.us, allenbh@gmail.com, Allen.Hubbe@emc.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH 6/8] ntb_tool: Add link status file to debugfs X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/06/16 09:45 AM, Allen Hubbe wrote: > > Feel free to disregard my suggestion above. I hope my comment has not cost you too much time. > > The way you have written it already, and used it in the self-test script is much more concise. > >>> + * root@self# echo > $DBG_DIR/link > > Acked-by: Allen.Hubbe@emc.com > > > > Eventually, I think it would be useful to let ntb_tool enable and disable the link. In that case, it might also be useful in a test script to wait for link down, not just link up. > > What about this: > > # Wait for the link to be up or down > root@self# echo 1 > $DBG_DIR/link > root@self# echo 0 > $DBG_DIR/link > > It need not be a part of this patch, but eventually: > > # Enable or disable the link > root@self# echo 1 > $DBG_DIR/link_ctrl > root@self# echo 0 > $DBG_DIR/link_ctrl > > # Reading the link_ctrl file can also give the link status > root@self# cat $DBG_DIR/link_ctrl > > Finally, I wonder if the file called "link" in this patch should be called "link_wait" or similar, so its purpose is obviously not for enabling and disabling the link. > Actually I've already implemented something similar to your original suggestion. I'll be submitting a v2 of this set shortly. Logan