From: Sasha Levin <sasha.levin@oracle.com>
To: Vishal Thanki <vishalthanki@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] liblockdep: Fix compile errors
Date: Tue, 14 Jun 2016 14:44:54 -0400 [thread overview]
Message-ID: <576050A6.2050202@oracle.com> (raw)
In-Reply-To: <1465901382-8216-1-git-send-email-vishalthanki@gmail.com>
On 06/14/2016 06:49 AM, Vishal Thanki wrote:
> diff --git a/tools/lib/lockdep/uinclude/linux/jhash.h b/tools/lib/lockdep/uinclude/linux/jhash.h
> new file mode 100644
> index 0000000..348c6f4
> --- /dev/null
> +++ b/tools/lib/lockdep/uinclude/linux/jhash.h
> @@ -0,0 +1,175 @@
> +#ifndef _LINUX_JHASH_H
Oh, we don't need to copy the whole thing. I was thinking about something like:
diff --git a/tools/lib/lockdep/uinclude/linux/unaligned/packed_struct.h b/tools/lib/lockdep/uinclude/linux/unaligned/packed_struct.h
new file mode 100644
index 0000000..7b204fc
--- /dev/null
+++ b/tools/lib/lockdep/uinclude/linux/unaligned/packed_struct.h
@@ -0,0 +1,2 @@
+#include "../../../include/linux/unaligned/packed_struct.h"
for both packed_struct.h and jhash.h. This was we get the advantage of having any
fixes to those headers automatically go into liblockdep as well.
Thanks,
Sasha
prev parent reply other threads:[~2016-06-14 18:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 10:49 [PATCH v2 1/2] liblockdep: Fix compile errors Vishal Thanki
2016-06-14 10:49 ` [PATCH v2 2/2] liblockdep: Remove -lpthread compiler option Vishal Thanki
2016-06-14 18:44 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=576050A6.2050202@oracle.com \
--to=sasha.levin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vishalthanki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox